Re: [PATCH v3 5/5] arm64: dts: rockchip: Follow the DTS coding style in the NanoPi RK3528 devicetrees

["Diederik de Haas" <diederik@cknow-tech.com>]

On Wed Sep 9, 2026 at 4:33 PM CEST, 安容 via B4 Relay wrote:
> From: 安容 <HystericalDragons@proton.me>
>
> scripts/dtc/dt-check-style --mode=strict reports two deviations from

I mentioned dt-check-style as it is a useful tool and it would be
beneficial if more/all future submissions were also checked with it.
I would not make it part of the commit message though.
Just like 'checkpatch' is a tool in the toolbox, so is dt-check-style.

> Documentation/devicetree/bindings/dts-coding-style.rst in the shared

Because the actual reason for this change is a violation of the DTS coding
style ... which I would put in the commit message.

> NanoPi RK3528 devicetree and in the NanoPi Zero2 board devicetree:
> "pinctrl-0" has to sort before "pinctrl-names", and "status" has to be
> preceded by a blank line when the node has content before it.
>
> Sort the properties and add the missing blank lines. The generated
> devicetree blobs are unchanged.

Making explicit which fixes you've done is fine AFAIC, but not strictly
needed as the diff already shows it. I would rather use "No functional
changes.", instead of 'blobs are unchanged'.

> The remaining findings of the tool are left alone, as they contradict
> the established practice in arch/arm64/boot/dts/rockchip: "model"
> before "compatible", "regulator-name" before the other regulator
> properties, "regulator-min-microvolt" before "regulator-max-microvolt",
> "pwms" before "pwm-supply" and "linux,code" before "wakeup-source" or
> "press-threshold-microvolt".

But as you noticed, it's not flawless. My guess is that it actually does
an alphanumerical sort, while the DTS coding style prescribes a natural
sorting. Dunno if there's an actual (enforceable) definition for it.

I would not list what I see as tool errors in the commit message though.

AFAIC no need for a new version for (just) this though.

My 0.02

Cheers,
  Diederik

> Suggested-by: Diederik de Haas <diederik@cknow-tech.com>
> Signed-off-by: 安容 <HystericalDragons@proton.me>
> ---
>  .../boot/dts/rockchip/rk3528-nanopi-zero2.dts      |  5 +++--
>  arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi    | 26 +++++++++++++++-------
>  2 files changed, 21 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts
> index 48e4273872..96c537da6a 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi-zero2.dts
> @@ -25,8 +25,8 @@ button-recovery {
>  
>  	leds {
>  		compatible = "gpio-leds";
> -		pinctrl-names = "default";
>  		pinctrl-0 = <&led1>, <&led_sys>;
> +		pinctrl-names = "default";
>  
>  		led-0 {
>  			color = <LED_COLOR_ID_RED>;
> @@ -59,8 +59,8 @@ usb2_host_5v: regulator-5v0-usb2-host {
>  		compatible = "regulator-fixed";
>  		enable-active-high;
>  		gpios = <&gpio4 RK_PB5 GPIO_ACTIVE_HIGH>;
> -		pinctrl-names = "default";
>  		pinctrl-0 = <&usb20_host1_pwren>;
> +		pinctrl-names = "default";
>  		regulator-name = "usb2_host_5v";
>  		regulator-min-microvolt = <5000000>;
>  		regulator-max-microvolt = <5000000>;
> @@ -96,5 +96,6 @@ &usb_host0_ohci {
>  
>  &usb2phy_host {
>  	phy-supply = <&usb2_host_5v>;
> +
>  	status = "okay";
>  };
> diff --git a/arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi b/arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi
> index 1980d14d6f..45e31b90a7 100644
> --- a/arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi
> +++ b/arch/arm64/boot/dts/rockchip/rk3528-nanopi.dtsi
> @@ -77,8 +77,8 @@ vcc_3v3: regulator-3v3-vcc {
>  	vcc3v3_sd: regulator-3v3-vcc-sd {
>  		compatible = "regulator-fixed";
>  		gpios = <&gpio4 RK_PA1 GPIO_ACTIVE_LOW>;
> -		pinctrl-names = "default";
>  		pinctrl-0 = <&sdmmc_pwren_l>;
> +		pinctrl-names = "default";
>  		regulator-name = "vcc3v3_sd";
>  		regulator-min-microvolt = <3300000>;
>  		regulator-max-microvolt = <3300000>;
> @@ -97,8 +97,8 @@ vcc5v0_sys: regulator-5v0-vcc-sys {
>  	vccio_sd: regulator-vccio-sd {
>  		compatible = "regulator-gpio";
>  		gpios = <&gpio4 RK_PB6 GPIO_ACTIVE_HIGH>;
> -		pinctrl-names = "default";
>  		pinctrl-0 = <&sdmmc_vol_ctrl_h>;
> +		pinctrl-names = "default";
>  		regulator-name = "vccio_sd";
>  		regulator-min-microvolt = <1800000>;
>  		regulator-max-microvolt = <3300000>;
> @@ -152,20 +152,23 @@ &gmac1 {
>  	phy-handle = <&rgmii_phy>;
>  	phy-mode = "rgmii-id";
>  	phy-supply = <&vcc_3v3>;
> -	pinctrl-names = "default";
>  	pinctrl-0 = <&rgmii_miim>, <&rgmii_tx_bus2>, <&rgmii_rx_bus2>,
>  		    <&rgmii_rgmii_clk>, <&rgmii_rgmii_bus>, <&gmac1_rstn_l>;
> +	pinctrl-names = "default";
> +
>  	status = "okay";
>  };
>  
>  &gpu {
>  	mali-supply = <&vdd_logic>;
> +
>  	status = "okay";
>  };
>  
>  &i2c1 {
> -	pinctrl-names = "default";
>  	pinctrl-0 = <&i2c1m0_xfer>;
> +	pinctrl-names = "default";
> +
>  	status = "okay";
>  
>  	hym8563: rtc@51 {
> @@ -174,8 +177,8 @@ hym8563: rtc@51 {
>  		#clock-cells = <0>;
>  		interrupt-parent = <&gpio4>;
>  		interrupts = <RK_PC1 IRQ_TYPE_LEVEL_LOW>;
> -		pinctrl-names = "default";
>  		pinctrl-0 = <&rtc_int_l>;
> +		pinctrl-names = "default";
>  		wakeup-source;
>  	};
>  };
> @@ -216,19 +219,22 @@ sdmmc_vol_ctrl_h: sdmmc-vol-ctrl-h {
>  };
>  
>  &pwm1 {
> -	pinctrl-names = "default";
>  	pinctrl-0 = <&pwm1m0_pins>;
> +	pinctrl-names = "default";
> +
>  	status = "okay";
>  };
>  
>  &pwm2 {
> -	pinctrl-names = "default";
>  	pinctrl-0 = <&pwm2m0_pins>;
> +	pinctrl-names = "default";
> +
>  	status = "okay";
>  };
>  
>  &saradc {
>  	vref-supply = <&vcc_1v8>;
> +
>  	status = "okay";
>  };
>  
> @@ -241,6 +247,7 @@ &sdhci {
>  	non-removable;
>  	vmmc-supply = <&vcc_3v3>;
>  	vqmmc-supply = <&vcc_1v8>;
> +
>  	status = "okay";
>  };
>  
> @@ -252,12 +259,14 @@ &sdmmc {
>  	sd-uhs-sdr104;
>  	vmmc-supply = <&vcc3v3_sd>;
>  	vqmmc-supply = <&vccio_sd>;
> +
>  	status = "okay";
>  };
>  
>  &uart0 {
> -	pinctrl-names = "default";
>  	pinctrl-0 = <&uart0m0_xfer>;
> +	pinctrl-names = "default";
> +
>  	status = "okay";
>  };
>  
> @@ -266,6 +275,7 @@ &usb_host0_xhci {
>  	maximum-speed = "high-speed";
>  	phys = <&usb2phy_otg>;
>  	phy-names = "usb2-phy";
> +
>  	status = "okay";
>  };
>