mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andrey Korshunov <razor1702@gmail.com>
To: devnull+hystericaldragons.proton.me@kernel.org
Cc: HystericalDragons@proton.me, amadeus@jmu.edu.cn,
	jensenhuang@friendlyarm.com, diederik@cknow-tech.com,
	heiko@sntech.de, robh@kernel.org, krzk+dt@kernel.org,
	conor+dt@kernel.org, linux-rockchip@lists.infradead.org,
	linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3 1/5] arm64: dts: rockchip: Reset the NanoPi Zero2 PHY from the MDIO bus
Date: Thu, 10 Sep 2026 01:50:02 +0300	[thread overview]
Message-ID: <20260909225002.976-1-razor1702@gmail.com> (raw)
In-Reply-To: <20260909-r28s-upstream-v3-1-ee3e1a34a353@proton.me>

On Wed Sep 9, 2026 at 10:33 PM CST, 安容 via B4 Relay wrote:
> Describe the reset on the MDIO bus instead. __mdiobus_register() asserts
> and releases the bus level reset-gpios before any device on the bus is
> registered, so the PHY responds whatever state the bootloader left it
> in.

Confirmed. And thanks for catching the deprecated properties I had
suggested - I had not read snps,dwmac.yaml, and dt-validate does not warn
on deprecated ones, so none of the checks I ran would have told me either.

I ran it both ways on a NanoPi R28S - same pin, same RTL8211F on mdio1 -
with two images that differ only in those nine lines of device tree. Both
are 6.18.44 with mainline U-Boot 2026.07 (generic-rk3528).

Reset in the PHY node, the way mainline describes it today:

  [    0.217516] mdio_bus stmmac-0: MDIO device at address 1 is missing.
  [   24.566496] rk_gmac-dwmac ffbe0000.ethernet eth0: cannot attach PHY

and the port stays down. Reset on the MDIO bus, as this patch does it:

  [   14.608938] rk_gmac-dwmac ffbe0000.ethernet eth0: PHY [stmmac-0:01] driver [RTL8211F Gigabit Ethernet] (irq=POLL)
  [   17.770103] rk_gmac-dwmac ffbe0000.ethernet eth0: Link is Up - 1Gbps/Full - flow control rx/tx

So U-Boot 2026.07 does leave the pin asserted, the same as the 2025.10 I
first saw this on - the commit message holds for the current release too,
not just the one I happened to report it from.

The one thing I cannot confirm is the board in the subject: this is an
R28S, not a Zero2, which I do not have.

Tested-by: Andrey Korshunov <razor1702@gmail.com>

Andrey

  reply	other threads:[~2026-09-09 22:50 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-09 14:33 [PATCH v3 0/5] arm64: dts: rockchip: Add FriendlyElec NanoPi R28S 安容 via B4 Relay
2026-09-09 14:33 ` [PATCH v3 1/5] arm64: dts: rockchip: Reset the NanoPi Zero2 PHY from the MDIO bus 安容 via B4 Relay
2026-09-09 22:50   ` Andrey Korshunov [this message]
2026-09-10  6:13     ` 安容
2026-09-11  6:55     ` Chukun Pan
2026-09-11 10:10       ` 安容
2026-09-09 14:33 ` [PATCH v3 2/5] dt-bindings: arm: rockchip: Add FriendlyElec NanoPi R28S 安容 via B4 Relay
2026-09-09 14:33 ` [PATCH v3 3/5] arm64: dts: rockchip: Split out the common NanoPi RK3528 parts 安容 via B4 Relay
2026-09-09 14:33 ` [PATCH v3 4/5] arm64: dts: rockchip: Add devicetree for the FriendlyElec NanoPi R28S 安容 via B4 Relay
2026-09-09 14:33 ` [PATCH v3 5/5] arm64: dts: rockchip: Follow the DTS coding style in the NanoPi RK3528 devicetrees 安容 via B4 Relay
2026-09-09 17:42   ` Diederik de Haas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260909225002.976-1-razor1702@gmail.com \
    --to=razor1702@gmail.com \
    --cc=HystericalDragons@proton.me \
    --cc=amadeus@jmu.edu.cn \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=devnull+hystericaldragons.proton.me@kernel.org \
    --cc=diederik@cknow-tech.com \
    --cc=heiko@sntech.de \
    --cc=jensenhuang@friendlyarm.com \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®