From: "Markus Schneider-Pargmann" <msp@baylibre.com>
To: "Joshua Crofts" <joshua.crofts1@gmail.com>,
"Markus Schneider-Pargmann" <msp@baylibre.com>,
"Marc Kleine-Budde" <mkl@pengutronix.de>,
"Vincent Mailhol" <mailhol@kernel.org>
Cc: <linux-can@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] can: m_can: pci: add missing pm_runtime_dont_use_autosuspend() call
Date: Fri, 18 Sep 2026 11:24:09 +0200 [thread overview]
Message-ID: <DLIC0I1VQLHE.13KVAJJ5FUYZN@baylibre.com> (raw)
In-Reply-To: <20260916124236.1389-1-joshua.crofts1@gmail.com>
[-- Attachment #1: Type: text/plain, Size: 464 bytes --]
Hi Joshua,
On Wed Sep 16, 2026 at 2:42 PM CEST, Joshua Crofts wrote:
> m_can_pci_remove() forgets to call pm_runtime_dont_use_autosuspend() on
> teardown, even though autosuspend is enabled in m_can_pci_probe().
>
> Add the missing function call.
>
Can you please add a Fixes: tag?
> Signed-off-by: Joshua Crofts <joshua.crofts1@gmail.com>
After that it looks good to me:
Acked-by: Markus Schneider-Pargmann <msp@baylibre.com>
Best
Markus
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 289 bytes --]
next prev parent reply other threads:[~2026-09-18 9:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-16 12:42 Joshua Crofts
2026-09-18 9:24 ` Markus Schneider-Pargmann [this message]
2026-09-18 11:15 ` Joshua Crofts
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DLIC0I1VQLHE.13KVAJJ5FUYZN@baylibre.com \
--to=msp@baylibre.com \
--cc=joshua.crofts1@gmail.com \
--cc=linux-can@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mailhol@kernel.org \
--cc=mkl@pengutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®