mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Danilo Krummrich" <dakr@kernel.org>
To: "Thorsten Blum" <blum@kernel.org>
Cc: "Alice Ryhl" <aliceryhl@google.com>,
	"Alexandre Courbot" <acourbot@nvidia.com>,
	"David Airlie" <airlied@gmail.com>,
	"Simona Vetter" <simona@ffwll.ch>, "Gary Guo" <gary@garyguo.net>,
	"Timur Tabi" <ttabi@nvidia.com>,
	"Robin Murphy" <robin.murphy@arm.com>,
	"Tim Kovalenko" <tim.kovalenko@proton.me>,
	<nova-gpu@lists.linux.dev>, <dri-devel@lists.freedesktop.org>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] gpu: nova-core: firmware: fwsec: use zeroed() to zero-pad buffers
Date: Wed, 07 Oct 2026 00:20:15 +0200	[thread overview]
Message-ID: <DLY3SJLA1YG0.1YBCCD2CAH2IC@kernel.org> (raw)
In-Reply-To: <20261006100442.80432-3-blum@kernel.org>

On Tue Oct 6, 2026 at 12:04 PM CEST, Thorsten Blum wrote:
> -            let mut ucode = KVec::with_capacity(aligned_code_size, GFP_KERNEL)?;
> -            ucode.extend_from_slice(code, GFP_KERNEL)?;
> -            ucode.resize(aligned_code_size, 0, GFP_KERNEL)?;
> -
> +            let mut ucode = KVec::zeroed(aligned_code_size, GFP_KERNEL)?;
> +            ucode[..code.len()].copy_from_slice(code);

I kinda dislike that this is now a potential panic, but it does better express
the intent.

Can you please add a corresponding // PANIC comment?

Thanks,
Danilo

  reply	other threads:[~2026-10-06 22:20 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 10:04 Thorsten Blum
2026-10-06 22:20 ` Danilo Krummrich [this message]
2026-10-07  0:33   ` Alexandre Courbot

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=DLY3SJLA1YG0.1YBCCD2CAH2IC@kernel.org \
    --to=dakr@kernel.org \
    --cc=acourbot@nvidia.com \
    --cc=airlied@gmail.com \
    --cc=aliceryhl@google.com \
    --cc=blum@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=gary@garyguo.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nova-gpu@lists.linux.dev \
    --cc=robin.murphy@arm.com \
    --cc=simona@ffwll.ch \
    --cc=tim.kovalenko@proton.me \
    --cc=ttabi@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®