mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] staging: greybus: Align function arguments
@ 2026-10-16  6:36 pavankumaryalagada
  2026-10-16 22:34 ` Ethan Tidmore
  0 siblings, 1 reply; 4+ messages in thread
From: pavankumaryalagada @ 2026-10-16  6:36 UTC (permalink / raw)
  To: pure.logic
  Cc: johan, elder, gregkh, rmfrfs, vireshk, greybus-dev,
	linux-staging, linux-kernel, outreachy, Yalagada Pavan Kumar

From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>

Align the function arguments to follow the coding style and
improve readability, addressing the alignment warning reported by
checkpatch.pl

Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
---
 drivers/staging/greybus/loopback.c | 3 ++-
 drivers/staging/greybus/spilib.c   | 3 ++-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/drivers/staging/greybus/loopback.c b/drivers/staging/greybus/loopback.c
index 2a623fc2e99b..0f699afc10f2 100644
--- a/drivers/staging/greybus/loopback.c
+++ b/drivers/staging/greybus/loopback.c
@@ -653,7 +653,8 @@ static int gb_loopback_request_handler(struct gb_operation *operation)
 		}
 
 		if (!gb_operation_response_alloc(operation,
-				len + sizeof(*response), GFP_KERNEL)) {
+						 len + sizeof(*response),
+						 GFP_KERNEL)) {
 			dev_err(dev, "error allocating response\n");
 			return -ENOMEM;
 		}
diff --git a/drivers/staging/greybus/spilib.c b/drivers/staging/greybus/spilib.c
index e4d1ae8308aa..c1982f3fb931 100644
--- a/drivers/staging/greybus/spilib.c
+++ b/drivers/staging/greybus/spilib.c
@@ -160,7 +160,8 @@ static struct spi_transfer *get_next_xfer(struct spi_transfer *xfer,
 
 /* Routines to transfer data */
 static struct gb_operation *gb_spi_operation_create(struct gb_spilib *spi,
-		struct gb_connection *connection, struct spi_message *msg)
+						    struct gb_connection *connection,
+						    struct spi_message *msg)
 {
 	struct gb_spi_transfer_request *request;
 	struct spi_device *dev = msg->spi;
-- 
2.43.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: greybus: Align function arguments
  2026-10-16  6:36 [PATCH] staging: greybus: Align function arguments pavankumaryalagada
@ 2026-10-16 22:34 ` Ethan Tidmore
  2026-10-16 23:49   ` Yalagada Pavan Kumar
  0 siblings, 1 reply; 4+ messages in thread
From: Ethan Tidmore @ 2026-10-16 22:34 UTC (permalink / raw)
  To: pavankumaryalagada, pure.logic
  Cc: johan, elder, gregkh, rmfrfs, vireshk, greybus-dev,
	linux-staging, linux-kernel, outreachy

On Fri Oct 16, 2026 at 1:36 AM CDT, pavankumaryalagada wrote:
> From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
>
> Align the function arguments to follow the coding style and
> improve readability, addressing the alignment warning reported by
> checkpatch.pl
>
> Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
> ---

This doesn't apply. Are you using staging-next?

Thanks,
ET

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: greybus: Align function arguments
  2026-10-16 22:34 ` Ethan Tidmore
@ 2026-10-16 23:49   ` Yalagada Pavan Kumar
  2026-10-17  1:53     ` Julia Lawall
  0 siblings, 1 reply; 4+ messages in thread
From: Yalagada Pavan Kumar @ 2026-10-16 23:49 UTC (permalink / raw)
  To: Ethan Tidmore
  Cc: pure.logic, johan, elder, gregkh, rmfrfs, vireshk, greybus-dev,
	linux-staging, linux-kernel, outreachy

On Fri, Oct 16, 2026 at 05:34:44PM -0500, Ethan Tidmore wrote:
> On Fri Oct 16, 2026 at 1:36 AM CDT, pavankumaryalagada wrote:
> > From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
> >
> > Align the function arguments to follow the coding style and
> > improve readability, addressing the alignment warning reported by
> > checkpatch.pl
> >
> > Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
> > ---
> 
> This doesn't apply. Are you using staging-next?

I'm not using staging-next for this patch.

Should i rebase it onto staging-next and send v2?

Thanks,
Pavan

> 
> Thanks,
> ET

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] staging: greybus: Align function arguments
  2026-10-16 23:49   ` Yalagada Pavan Kumar
@ 2026-10-17  1:53     ` Julia Lawall
  0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2026-10-17  1:53 UTC (permalink / raw)
  To: Yalagada Pavan Kumar
  Cc: Ethan Tidmore, pure.logic, johan, elder, gregkh, rmfrfs, vireshk,
	greybus-dev, linux-staging, linux-kernel, outreachy


Sent from my iPhone

> On 16 Oct 2026, at 19:50, Yalagada Pavan Kumar <pavankumaryalagada@gmail.com> wrote:
> 
> On Fri, Oct 16, 2026 at 05:34:44PM -0500, Ethan Tidmore wrote:
>>> On Fri Oct 16, 2026 at 1:36 AM CDT, pavankumaryalagada wrote:
>>> From: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
>>> 
>>> Align the function arguments to follow the coding style and
>>> improve readability, addressing the alignment warning reported by
>>> checkpatch.pl
>>> 
>>> Signed-off-by: Yalagada Pavan Kumar <pavankumaryalagada@gmail.com>
>>> ---
>> 
>> This doesn't apply. Are you using staging-next?
> 
> I'm not using staging-next for this patch.
> 
> Should i rebase it onto staging-next and send v2?

Yes

> 
> Thanks,
> Pavan
> 
>> 
>> Thanks,
>> ET
> 


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2026-10-17  1:53 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-16  6:36 [PATCH] staging: greybus: Align function arguments pavankumaryalagada
2026-10-16 22:34 ` Ethan Tidmore
2026-10-16 23:49   ` Yalagada Pavan Kumar
2026-10-17  1:53     ` Julia Lawall

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®