* [PATCH] staging: greybus: fw-management: fix argument alignment
@ 2026-10-18 22:42 Okhuomon Ajayi
2026-10-19 1:47 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Okhuomon Ajayi @ 2026-10-18 22:42 UTC (permalink / raw)
To: outreachy
Cc: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
greybus-dev, linux-staging, linux-kernel, Okhuomon Ajayi
Align the arguments of the fw_mgmt_load_and_validate_operation()
call with the opening parenthesis and split them across separate
lines to avoid an overly long line.
CHECK: Alignment should match open parenthesis
Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
drivers/staging/greybus/fw-management.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/staging/greybus/fw-management.c b/drivers/staging/greybus/fw-management.c
index 5d01da6b6eb9..e20e9136c106 100644
--- a/drivers/staging/greybus/fw-management.c
+++ b/drivers/staging/greybus/fw-management.c
@@ -434,7 +434,8 @@ static int fw_mgmt_ioctl(struct fw_mgmt *fw_mgmt, unsigned int cmd,
return -EFAULT;
ret = fw_mgmt_load_and_validate_operation(fw_mgmt,
- intf_load.load_method, intf_load.firmware_tag);
+ intf_load.load_method,
+ intf_load.firmware_tag);
if (ret)
return ret;
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: greybus: fw-management: fix argument alignment
2026-10-18 22:42 [PATCH] staging: greybus: fw-management: fix argument alignment Okhuomon Ajayi
@ 2026-10-19 1:47 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-10-19 1:47 UTC (permalink / raw)
To: Okhuomon Ajayi, outreachy
Cc: Viresh Kumar, Johan Hovold, Alex Elder, Greg Kroah-Hartman,
greybus-dev, linux-staging, linux-kernel
On Sun Oct 18, 2026 at 5:42 PM CDT, Okhuomon Ajayi wrote:
> Align the arguments of the fw_mgmt_load_and_validate_operation()
> call with the opening parenthesis and split them across separate
> lines to avoid an overly long line.
>
> CHECK: Alignment should match open parenthesis
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
LGTM.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-19 1:48 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-18 22:42 [PATCH] staging: greybus: fw-management: fix argument alignment Okhuomon Ajayi
2026-10-19 1:47 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®