* [PATCH] staging: octeon: remove unused cvm_oct_transmit_qos declaration
@ 2026-10-18 23:15 Okhuomon Ajayi
2026-10-19 1:51 ` Ethan Tidmore
0 siblings, 1 reply; 2+ messages in thread
From: Okhuomon Ajayi @ 2026-10-18 23:15 UTC (permalink / raw)
To: outreachy; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel, Okhuomon Ajayi
The cvm_oct_transmit_qos() function was removed by commit
6568a2343639 ("Staging: Octeon Ethernet: Remove unused code."),
but its declaration in ethernet-tx.h was left behind.
Remove the unused declaration.
Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
---
drivers/staging/octeon/ethernet-tx.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/octeon/ethernet-tx.h b/drivers/staging/octeon/ethernet-tx.h
index b03d56b0d2b6..498a5d68407d 100644
--- a/drivers/staging/octeon/ethernet-tx.h
+++ b/drivers/staging/octeon/ethernet-tx.h
@@ -7,8 +7,6 @@
netdev_tx_t cvm_oct_xmit(struct sk_buff *skb, struct net_device *dev);
netdev_tx_t cvm_oct_xmit_pow(struct sk_buff *skb, struct net_device *dev);
-int cvm_oct_transmit_qos(struct net_device *dev, void *work_queue_entry,
- int do_free, int qos);
int cvm_oct_tx_initialize(struct platform_device *pdev);
void cvm_oct_tx_shutdown(void);
void cvm_oct_tx_shutdown_dev(struct net_device *dev);
--
2.43.0
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH] staging: octeon: remove unused cvm_oct_transmit_qos declaration
2026-10-18 23:15 [PATCH] staging: octeon: remove unused cvm_oct_transmit_qos declaration Okhuomon Ajayi
@ 2026-10-19 1:51 ` Ethan Tidmore
0 siblings, 0 replies; 2+ messages in thread
From: Ethan Tidmore @ 2026-10-19 1:51 UTC (permalink / raw)
To: Okhuomon Ajayi, outreachy; +Cc: Greg Kroah-Hartman, linux-staging, linux-kernel
On Sun Oct 18, 2026 at 6:15 PM CDT, Okhuomon Ajayi wrote:
> The cvm_oct_transmit_qos() function was removed by commit
> 6568a2343639 ("Staging: Octeon Ethernet: Remove unused code."),
> but its declaration in ethernet-tx.h was left behind.
>
> Remove the unused declaration.
>
> Signed-off-by: Okhuomon Ajayi <okhuomonajayi54@gmail.com>
> ---
LGTM.
However, please wait atleast 24 hours in between submitting patches so
the mailing list doesn't get cluttered, thanks.
Reviewed-by: Ethan Tidmore <ethantidmore06@gmail.com>
Thanks,
ET
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-10-19 1:51 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-18 23:15 [PATCH] staging: octeon: remove unused cvm_oct_transmit_qos declaration Okhuomon Ajayi
2026-10-19 1:51 ` Ethan Tidmore
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®