* [PATCH] mm/page_alloc: remove unneeded forward declaration of __free_pages_ok()
@ 2026-10-22 12:45 Zenghui Yu
2026-10-22 14:12 ` Zi Yan
2026-10-22 16:43 ` Johannes Weiner
0 siblings, 2 replies; 3+ messages in thread
From: Zenghui Yu @ 2026-10-22 12:45 UTC (permalink / raw)
To: linux-mm, linux-kernel
Cc: akpm, vbabka, surenb, mhocko, brendan.jackman, hannes, ziy,
Zenghui Yu (Huawei)
From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
All remaining callers of __free_pages_ok() appear after its definition, so
the forward declaration near the top of mm/page_alloc.c is no longer
needed. Remove it.
Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
---
mm/page_alloc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/mm/page_alloc.c b/mm/page_alloc.c
index 0396c50b96f0..6db90e0aa929 100644
--- a/mm/page_alloc.c
+++ b/mm/page_alloc.c
@@ -216,8 +216,6 @@ gfp_t gfp_allowed_mask __read_mostly = GFP_BOOT_MASK;
unsigned int pageblock_order __read_mostly;
#endif
-static void __free_pages_ok(struct page *page, unsigned int order,
- fpi_t fpi_flags);
static void reserve_highatomic_pageblock(struct page *page, int order,
struct zone *zone);
--
2.56.0
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/page_alloc: remove unneeded forward declaration of __free_pages_ok()
2026-10-22 12:45 [PATCH] mm/page_alloc: remove unneeded forward declaration of __free_pages_ok() Zenghui Yu
@ 2026-10-22 14:12 ` Zi Yan
2026-10-22 16:43 ` Johannes Weiner
1 sibling, 0 replies; 3+ messages in thread
From: Zi Yan @ 2026-10-22 14:12 UTC (permalink / raw)
To: Zenghui Yu, linux-mm, linux-kernel
Cc: akpm, vbabka, surenb, mhocko, brendan.jackman, hannes
On Thu Oct 22, 2026 at 8:45 AM EDT, Zenghui Yu wrote:
> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
>
> All remaining callers of __free_pages_ok() appear after its definition, so
> the forward declaration near the top of mm/page_alloc.c is no longer
> needed. Remove it.
>
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
> ---
> mm/page_alloc.c | 2 --
> 1 file changed, 2 deletions(-)
>
LGTM. Thanks.
Reviewed-by: Zi Yan <ziy@nvidia.com>
--
Best Regards,
Yan, Zi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] mm/page_alloc: remove unneeded forward declaration of __free_pages_ok()
2026-10-22 12:45 [PATCH] mm/page_alloc: remove unneeded forward declaration of __free_pages_ok() Zenghui Yu
2026-10-22 14:12 ` Zi Yan
@ 2026-10-22 16:43 ` Johannes Weiner
1 sibling, 0 replies; 3+ messages in thread
From: Johannes Weiner @ 2026-10-22 16:43 UTC (permalink / raw)
To: Zenghui Yu
Cc: linux-mm, linux-kernel, akpm, vbabka, surenb, mhocko,
brendan.jackman, ziy
On Thu, Oct 22, 2026 at 08:45:04PM +0800, Zenghui Yu wrote:
> From: "Zenghui Yu (Huawei)" <zenghui.yu@linux.dev>
>
> All remaining callers of __free_pages_ok() appear after its definition, so
> the forward declaration near the top of mm/page_alloc.c is no longer
> needed. Remove it.
>
> Signed-off-by: Zenghui Yu (Huawei) <zenghui.yu@linux.dev>
Reviewed-by: Johannes Weiner <hannes@cmpxchg.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2026-10-22 16:43 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-22 12:45 [PATCH] mm/page_alloc: remove unneeded forward declaration of __free_pages_ok() Zenghui Yu
2026-10-22 14:12 ` Zi Yan
2026-10-22 16:43 ` Johannes Weiner
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®