From: "Luca Ceresoli" <luca.ceresoli@bootlin.com>
To: "Maíra Canal" <mcanal@igalia.com>,
"Luca Ceresoli" <luca.ceresoli@bootlin.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Dave Stevenson" <dave.stevenson@raspberrypi.com>,
"Raspberry Pi Kernel Maintenance" <kernel-list@raspberrypi.com>,
"Maarten Lankhorst" <maarten.lankhorst@linux.intel.com>,
"Thomas Zimmermann" <tzimmermann@suse.de>,
"David Airlie" <airlied@gmail.com>,
"Simona Vetter" <simona@ffwll.ch>
Cc: "Paul Cercueil" <paul.cercueil@bootlin.com>,
"Hui Pu" <Hui.Pu@gehealthcare.com>,
"Ian Ray" <ian.ray@gehealthcare.com>,
"Thomas Petazzoni" <thomas.petazzoni@bootlin.com>,
<dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 3/3] drm/vc4: dpi: inline vc4_dpi_init_bridge() into vc4_dpi_bind()
Date: Thu, 05 Nov 2026 10:57:56 +0100 [thread overview]
Message-ID: <DMN6SIQLWFK7.2O38VBNNDP1RX@bootlin.com> (raw)
In-Reply-To: <1202bdc6-afde-45e1-8a32-c64f9424a65d@igalia.com>
Hi Maíra,
On Sat Oct 24, 2026 at 3:03 PM CEST, Maíra Canal wrote:
> Hi Luca,
>
> If you go ahead with this patch, could you merge it with [1/3]
> Personally, I prefer to keep it as a separate function. vc4_dpi_bind()
> is already a big function, with several initializations. I have the
> impression that vc4_dpi_init_bridge() makes the error handling more
> clear.
I agree, and that's why this inlining was not in my initial work. It was
suggested by Paul, but since there are other opinions against it I'll just
drop this patch.
Luca
--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
prev parent reply other threads:[~2026-11-05 9:58 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-13 15:23 [PATCH v3 0/3] drm: remove deprecated *_of_get_bridge() from non-OF drivers Luca Ceresoli
2026-10-13 15:23 ` [PATCH v3 1/3] drm/vc4: dpi: stop using deprecated drmm_of_get_bridge() Luca Ceresoli
2026-10-24 12:57 ` Maíra Canal
2026-10-13 15:23 ` [PATCH v3 2/3] drm/vc4: dsi: " Luca Ceresoli
2026-10-24 12:56 ` Maíra Canal
2026-11-05 10:28 ` Luca Ceresoli
2026-10-13 15:23 ` [PATCH v3 3/3] drm/vc4: dpi: inline vc4_dpi_init_bridge() into vc4_dpi_bind() Luca Ceresoli
2026-10-24 13:03 ` Maíra Canal
2026-11-05 9:57 ` Luca Ceresoli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMN6SIQLWFK7.2O38VBNNDP1RX@bootlin.com \
--to=luca.ceresoli@bootlin.com \
--cc=Hui.Pu@gehealthcare.com \
--cc=airlied@gmail.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=ian.ray@gehealthcare.com \
--cc=kernel-list@raspberrypi.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mcanal@igalia.com \
--cc=mripard@kernel.org \
--cc=paul.cercueil@bootlin.com \
--cc=simona@ffwll.ch \
--cc=thomas.petazzoni@bootlin.com \
--cc=tzimmermann@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®