Re: [PATCH v3 2/3] drm/vc4: dsi: stop using deprecated drmm_of_get_bridge()

["Luca Ceresoli" <luca.ceresoli@bootlin.com>]

On Sat Oct 24, 2026 at 2:56 PM CEST, Maíra Canal wrote:
> Hi Luca,
>
> On 13/10/26 12:23, Luca Ceresoli wrote:
>> drmm_of_get_bridge() is deprecated, switch to
>> of_drm_get_bridge_by_endpoint(). As of_drm_get_bridge_by_endpoint() returns
>> a refcounted bridge, ensure it is put by using bridge.next_bridge.
>>
>> drm_panel.h becomes unused, drop the include.
>>
>> Signed-off-by: Luca Ceresoli <luca.ceresoli@bootlin.com>

...

>> @@ -1165,7 +1163,7 @@ static int vc4_dsi_bridge_attach(struct drm_bridge *bridge,
>>   	struct vc4_dsi *dsi = bridge_to_vc4_dsi(bridge);
>
> I believe you can delete *dsi
>
>>
>>   	/* Attach the panel or bridge to the dsi bridge */
>> -	return drm_bridge_attach(encoder, dsi->out_bridge,
>> +	return drm_bridge_attach(encoder, dsi->bridge.next_bridge,
>
> and use drm_bridge_attach(encoder, bridge->next_bridge, bridge, flags).

Good point. I did this in v4 as a new patch, to keep this one patch
readable.

> Also, I believe the comment is now redundant as panels are just bridges.

Indeed, done.

> Apart from these nits, could you also address Sashiko's feedback?

Sure, fixed in v4.

Thanks for reviewing!

Luca

--
Luca Ceresoli, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com