Re: [PATCH RESEND v4 2/3] arm64: dts: qcom: Add sm8250-oneplus-common.dtsi

["Frieder Hannenheim" <mail@fhannenheim.net>]

On Sun Nov 8, 2026 at 10:05 PM CET, David Heidelberg wrote:
> On 05/11/2026 20:20, Frieder Hannenheim wrote:
>> This file contains common properties shared by all OnePlus devices using
>> the Qualcomm sm8250 chipset.
>> 
>> Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
>> Signed-off-by: Robert Oscilowski <drgitx@gmail.com>
>> Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
>> ---
>>   .../arm64/boot/dts/qcom/sm8250-oneplus-common.dtsi | 607 +++++++++++++++++++++
>>   1 file changed, 607 insertions(+)
>> 
>
> [...]
>
>> +
>> +	gpio_keys: gpio-keys {
>> +		compatible = "gpio-keys";
>> +		label = "Volume keys";
>> +
>> +		pinctrl-0 = <&vol_down_l &vol_up_n>;
>> +		pinctrl-names = "default";
>> +
>> +		key-vol-down {
>> +			label = "Volume Down";
>> +			linux,code = <KEY_VOLUMEDOWN>;
>
> Hello Frieder,
>
> patch looks good, but I noticed - which one? this key-vol-down or later at bottom,
>

Hmm well the pon_resin doesn't seem to emit input events. I don't know if it's
used for anything else but the volume down button still works if I drop it.

>> +			gpios = <&pm8150_gpios 7 GPIO_ACTIVE_LOW>;
>> +			debounce-interval = <15>;
>> +			linux,can-disable;
>> +			wakeup-source;
>> +		};
>> +
>> +		key-vol-up {
>> +			label = "Volume Up";
>> +			gpios = <&pm8150_gpios 6 GPIO_ACTIVE_LOW>;
>> +			linux,code = <KEY_VOLUMEUP>;
>> +			debounce-interval = <15>;
>> +			linux,can-disable;
>> +			wakeup-source;
>> +		};
>> +	};
>> +
>
> [...]
>
>> +&pon_pwrkey {
>> +	status = "okay";
>> +};
>> +
>> +&pon_resin {
>> +	linux,code = <KEY_VOLUMEDOWN>;
>
> or this one?
>
> David
>
> [...]

Thanks for mentioning this. I had already tried disabling the gpio key and just
using the resin. I will drop the resin in the next version.

Frieder