mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>
To: Frieder Hannenheim <git@fhannenheim.net>,
	Bjorn Andersson <andersson@kernel.org>,
	Konrad Dybcio <konradybcio@kernel.org>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>
Cc: "Robert Oscilowski" <drgitx@gmail.com>,
	"Jean-François Bobier" <jf.bobier@gmail.com>,
	phone-devel@vger.kernel.org, linux-arm-msm@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND v4 3/3] arm64: dts: qcom: oneplus-kebab: new device
Date: Mon, 9 Nov 2026 12:08:11 +0100	[thread overview]
Message-ID: <c25371d5-1693-4ab6-9b4a-7b17a38a4e09@oss.qualcomm.com> (raw)
In-Reply-To: <20261105-kebab_dts-v4-3-c6bbe6ded92e@fhannenheim.net>

On 11/5/26 9:20 PM, Frieder Hannenheim wrote:
> Add initial device-tree for the OnePlus 8T. Downstream reference is [1].
> 
> [1] https://github.com/LineageOS/android_kernel_oneplus_sm8250/blob/lineage-23.2/arch/arm64/boot/dts/vendor/oplus/kona-kebab-overlay.dts
> 
> Co-developed-by: Robert Oscilowski <drgitx@gmail.com>
> Signed-off-by: Robert Oscilowski <drgitx@gmail.com>
> Signed-off-by: Frieder Hannenheim <git@fhannenheim.net>
> ---

[...]

> +&i2c2 {
> +	status = "okay";
> +
> +	pm8008: pmic@8 {
> +		compatible = "qcom,pm8008";

No PM8008 on the other phone?

> +		reg = <0x8>;
> +
> +		interrupt-parent = <&tlmm>;
> +		interrupts = <112 IRQ_TYPE_EDGE_RISING>;

interrupts-extended = <&tlmm 112 IRQ..>

[...]

> +&vreg_f {
> +	status = "disabled";
> +};

I think it may be cleaner to move the definition to the other
phone's DT (are there just 2, or more?)

Konrad

      reply	other threads:[~2026-11-09 11:08 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05 20:20 [PATCH RESEND v4 0/3] Add OnePlus 8T Frieder Hannenheim
2026-11-05 20:20 ` [PATCH RESEND v4 1/3] dt-bindings: arm: qcom: Document " Frieder Hannenheim
2026-11-08 20:52   ` David Heidelberg
2026-11-08 20:58     ` Frieder Hannenheim
2026-11-08 21:03       ` David Heidelberg
2026-11-09 11:06       ` Konrad Dybcio
2026-11-05 20:20 ` [PATCH RESEND v4 2/3] arm64: dts: qcom: Add sm8250-oneplus-common.dtsi Frieder Hannenheim
2026-11-08 21:05   ` David Heidelberg
2026-11-09 10:36     ` Frieder Hannenheim
2026-11-05 20:20 ` [PATCH RESEND v4 3/3] arm64: dts: qcom: oneplus-kebab: new device Frieder Hannenheim
2026-11-09 11:08   ` Konrad Dybcio [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c25371d5-1693-4ab6-9b4a-7b17a38a4e09@oss.qualcomm.com \
    --to=konrad.dybcio@oss.qualcomm.com \
    --cc=andersson@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=drgitx@gmail.com \
    --cc=git@fhannenheim.net \
    --cc=jf.bobier@gmail.com \
    --cc=konradybcio@kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=phone-devel@vger.kernel.org \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®