From: "Luca Weiss" <luca.weiss@fairphone.com>
To: "Luca Weiss" <luca.weiss@fairphone.com>,
"Bjorn Andersson" <andersson@kernel.org>,
"Konrad Dybcio" <konradybcio@kernel.org>,
"Abel Vesa" <abelvesa@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Dmitry Baryshkov" <dmitry.baryshkov@oss.qualcomm.com>,
"Val Packett" <val@packett.cool>
Cc: <~postmarketos/upstreaming@lists.sr.ht>,
<phone-devel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-arm-msm@vger.kernel.org>, <devicetree@vger.kernel.org>
Subject: Re: [PATCH 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Wire up PM6150L LCDB
Date: Fri, 13 Nov 2026 13:59:58 +0100 [thread overview]
Message-ID: <DMU3O9G3L6PD.2CE9WCHR9LV0J@fairphone.com> (raw)
In-Reply-To: <20261113-lcdb-enablement-v1-4-1dc40b49ed82@fairphone.com>
On Fri Nov 13, 2026 at 9:16 AM CET, Luca Weiss wrote:
> Since Linux has gained LCDB support now, wire up the LCDB regulators so
> we can turn them off and on as desired.
Actually after some more testing with extra patches, it seems that on
FP4 the touchscreen stays dead after toggling the lcdb regulator, while
on FP3 it works perfectly fine.
So please ignore this specific patch for now, I will figure out what the
problem is and re-submit. All the other patches in the series are still
good to go in!
Regards
Luca
> Signed-off-by: Luca Weiss <luca.weiss@fairphone.com>
> ---
> arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts | 26 ++++++++++++++---------
> 1 file changed, 16 insertions(+), 10 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> index 37aa272019cc..d592bede6a61 100644
> --- a/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> +++ b/arch/arm64/boot/dts/qcom/sm7225-fairphone-fp4.dts
> @@ -72,14 +72,6 @@ key-volume-up {
> };
> };
>
> - /* Dummy regulator until PM6150L has LCDB VSP/VSN support */
> - lcdb_dummy: regulator-lcdb-dummy {
> - compatible = "regulator-fixed";
> - regulator-name = "lcdb_dummy";
> - regulator-min-microvolt = <5500000>;
> - regulator-max-microvolt = <5500000>;
> - };
> -
> reserved-memory {
> /*
> * The rmtfs memory region in downstream is 'dynamically allocated'
> @@ -784,8 +776,8 @@ panel@0 {
> reset-gpios = <&pm6150l_gpios 9 GPIO_ACTIVE_LOW>;
>
> vdd1-supply = <&vreg_l1e>;
> - vsn-supply = <&lcdb_dummy>;
> - vsp-supply = <&lcdb_dummy>;
> + vsn-supply = <&pm6150l_lcdb_ncp>;
> + vsp-supply = <&pm6150l_lcdb_ldo>;
>
> port {
> panel_in: endpoint {
> @@ -925,6 +917,20 @@ pm6150l_adc_default: adc-default-state {
> };
> };
>
> +&pm6150l_lcdb {
> + status = "okay";
> +};
> +
> +&pm6150l_lcdb_ldo {
> + regulator-min-microvolt = <5500000>;
> + regulator-max-microvolt = <5500000>;
> +};
> +
> +&pm6150l_lcdb_ncp {
> + regulator-min-microvolt = <5500000>;
> + regulator-max-microvolt = <5500000>;
> +};
> +
> &pm6150l_wled {
> qcom,switching-freq = <800>;
> qcom,current-limit-microamp = <20000>;
next prev parent reply other threads:[~2026-11-13 13:00 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-13 8:16 [PATCH 0/4] Wire up LCDB regulator on Fairphone 3 & Fairphone 4 Luca Weiss
2026-11-13 8:16 ` [PATCH 1/4] arm64: defconfig: Enable Qualcomm LCDB regulator Luca Weiss
2026-11-13 8:16 ` [PATCH 2/4] arm64: dts: qcom: sdm632-fairphone-fp3: Wire up PMI632 LCDB Luca Weiss
2026-11-13 8:16 ` [PATCH 3/4] arm64: dts: qcom: pm6150l: add LCDB regulators Luca Weiss
2026-11-13 8:16 ` [PATCH 4/4] arm64: dts: qcom: sm7225-fairphone-fp4: Wire up PM6150L LCDB Luca Weiss
2026-11-13 12:59 ` Luca Weiss [this message]
2026-11-13 13:09 ` Val Packett
2026-11-13 13:27 ` Luca Weiss
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DMU3O9G3L6PD.2CE9WCHR9LV0J@fairphone.com \
--to=luca.weiss@fairphone.com \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh@kernel.org \
--cc=val@packett.cool \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®