* [PATCH] rust: cfi: disable function merging if CFI is enabled @ 2026-08-20 13:57 Gary Guo 2026-08-20 15:58 ` Gary Guo 2026-08-24 1:15 ` Miguel Ojeda 0 siblings, 2 replies; 10+ messages in thread From: Gary Guo @ 2026-08-20 13:57 UTC (permalink / raw) To: Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Gary Guo, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt Cc: kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm From: Gary Guo <gary@garyguo.net> In Rust doc tests, there is a dummy `__module_firmware_test_init` function generated by the example in `module_firmware!`'s documentation, which just returns zero. Many other documentation generates function that produces zero. LKP test robot reports a `Flags::zeroed` instance; my local reproduction has a `Bounded::new::<0>`. LLVM's MergeFunctionsPass incorrectly merge functions with the same KCFI type, causing `__module_firmware_test_init` being merged into one of the zero-returning function. As module init is invoked via indirect function call, KCFI is checked and this produces a KCFI failure. I've reported this bug to upstream LLVM [1]; in the mean time, disable function merging if CFI is enabled. No separate treatment is needed for CONFIG_RUST_INLINE_HELPERS, as Clang does not enable function merging by default. Reported-by: kernel test robot <yi1.lai@intel.com> Closes: https://lore.kernel.org/oe-lkp/202608201017.100a4511-lkp@intel.com Link: https://github.com/llvm/llvm-project/issues/217629 [1] Signed-off-by: Gary Guo <gary@garyguo.net> --- Makefile | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 4fee5ee9e9f4..0dd9a6eda739 100644 --- a/Makefile +++ b/Makefile @@ -1118,7 +1118,8 @@ endif ifdef CONFIG_RUST # Always pass -Zsanitizer-cfi-normalize-integers as CONFIG_RUST selects # CONFIG_CFI_ICALL_NORMALIZE_INTEGERS. - RUSTC_FLAGS_CFI := -Zsanitizer=kcfi -Zsanitizer-cfi-normalize-integers + # Disable function merging as LLVM incorrectly merge functions with the same KCFI type. + RUSTC_FLAGS_CFI := -Zsanitizer=kcfi -Zsanitizer-cfi-normalize-integers -Zmerge-functions=disabled KBUILD_RUSTFLAGS += $(RUSTC_FLAGS_CFI) export RUSTC_FLAGS_CFI endif base-commit: e6664f2b33db9b6811eb4cec109f06cb2b4f458d -- 2.54.0 ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-08-20 13:57 [PATCH] rust: cfi: disable function merging if CFI is enabled Gary Guo @ 2026-08-20 15:58 ` Gary Guo 2026-08-20 23:42 ` Sami Tolvanen 2026-08-24 1:15 ` Miguel Ojeda 1 sibling, 1 reply; 10+ messages in thread From: Gary Guo @ 2026-08-20 15:58 UTC (permalink / raw) To: Gary Guo, Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt Cc: kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Thu Aug 20, 2026 at 2:57 PM BST, Gary Guo wrote: > From: Gary Guo <gary@garyguo.net> > > In Rust doc tests, there is a dummy `__module_firmware_test_init` function > generated by the example in `module_firmware!`'s documentation, which just > returns zero. Many other documentation generates function that produces > zero. LKP test robot reports a `Flags::zeroed` instance; my local > reproduction has a `Bounded::new::<0>`. > > LLVM's MergeFunctionsPass incorrectly merge functions with the same KCFI This should read "with different KCFI type" (obviously). Best, Gary > type, causing `__module_firmware_test_init` being merged into one of the > zero-returning function. As module init is invoked via indirect function > call, KCFI is checked and this produces a KCFI failure. > > I've reported this bug to upstream LLVM [1]; in the mean time, disable > function merging if CFI is enabled. No separate treatment is needed for > CONFIG_RUST_INLINE_HELPERS, as Clang does not enable function merging by > default. > > Reported-by: kernel test robot <yi1.lai@intel.com> > Closes: https://lore.kernel.org/oe-lkp/202608201017.100a4511-lkp@intel.com > Link: https://github.com/llvm/llvm-project/issues/217629 [1] > Signed-off-by: Gary Guo <gary@garyguo.net> > --- > Makefile | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 4fee5ee9e9f4..0dd9a6eda739 100644 > --- a/Makefile > +++ b/Makefile > @@ -1118,7 +1118,8 @@ endif > ifdef CONFIG_RUST > # Always pass -Zsanitizer-cfi-normalize-integers as CONFIG_RUST selects > # CONFIG_CFI_ICALL_NORMALIZE_INTEGERS. > - RUSTC_FLAGS_CFI := -Zsanitizer=kcfi -Zsanitizer-cfi-normalize-integers > + # Disable function merging as LLVM incorrectly merge functions with the same KCFI type. > + RUSTC_FLAGS_CFI := -Zsanitizer=kcfi -Zsanitizer-cfi-normalize-integers -Zmerge-functions=disabled > KBUILD_RUSTFLAGS += $(RUSTC_FLAGS_CFI) > export RUSTC_FLAGS_CFI > endif > > base-commit: e6664f2b33db9b6811eb4cec109f06cb2b4f458d ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-08-20 15:58 ` Gary Guo @ 2026-08-20 23:42 ` Sami Tolvanen 2026-08-21 9:20 ` Miguel Ojeda 0 siblings, 1 reply; 10+ messages in thread From: Sami Tolvanen @ 2026-08-20 23:42 UTC (permalink / raw) To: Gary Guo Cc: Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Thu, Aug 20, 2026 at 9:06 AM Gary Guo <gary@garyguo.net> wrote: > > On Thu Aug 20, 2026 at 2:57 PM BST, Gary Guo wrote: > > From: Gary Guo <gary@garyguo.net> > > > > In Rust doc tests, there is a dummy `__module_firmware_test_init` function > > generated by the example in `module_firmware!`'s documentation, which just > > returns zero. Many other documentation generates function that produces > > zero. LKP test robot reports a `Flags::zeroed` instance; my local > > reproduction has a `Bounded::new::<0>`. > > > > LLVM's MergeFunctionsPass incorrectly merge functions with the same KCFI > > This should read "with different KCFI type" (obviously). Also the comment in the Makefile. With both instances fixed: Reviewed-by: Sami Tolvanen <samitolvanen@google.com> The LLVM fix itself is trivial, and it looks like a pull request for it already exists. I assume we'll want to drop this flag for fixed LLVM versions when they're available. Sami ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-08-20 23:42 ` Sami Tolvanen @ 2026-08-21 9:20 ` Miguel Ojeda 2026-11-17 20:58 ` Alice Ryhl 0 siblings, 1 reply; 10+ messages in thread From: Miguel Ojeda @ 2026-08-21 9:20 UTC (permalink / raw) To: Sami Tolvanen Cc: Gary Guo, Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Fri, Aug 21, 2026 at 1:43 AM Sami Tolvanen <samitolvanen@google.com> wrote: > > The LLVM fix itself is trivial, and it looks like a pull request for > it already exists. I assume we'll want to drop this flag for fixed > LLVM versions when they're available. I will link it in the commit message when I pick it up soon -- already did in https://github.com/Rust-for-Linux/linux/issues/1132. I also added the `-Z` flag to https://github.com/Rust-for-Linux/linux/issues/2. The `-Zmerge-functions` flag is internal but has been there since Rust 1.34.0 in upstream commit: b91d211b4030 ("Add a target option "merge-functions" taking values in ("disabled", "trampolines", or "aliases (the default)) to allow targets to opt out of the MergeFunctions LLVM pass. Also add a corresponding -Z option with the same name and values.") so that should be fine, but I will ping upstream Rust so that they are aware we are using it. And, yeah, agreed, we probably should remove the flag conditionally later on, to confirm the bug is gone etc. Cheers, Miguel ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-08-21 9:20 ` Miguel Ojeda @ 2026-11-17 20:58 ` Alice Ryhl 2026-11-17 22:03 ` Sami Tolvanen 2026-11-18 11:25 ` Gary Guo 0 siblings, 2 replies; 10+ messages in thread From: Alice Ryhl @ 2026-11-17 20:58 UTC (permalink / raw) To: Miguel Ojeda Cc: Sami Tolvanen, Gary Guo, Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Fri, Aug 21, 2026 at 11:20:18AM +0200, Miguel Ojeda wrote: > On Fri, Aug 21, 2026 at 1:43 AM Sami Tolvanen <samitolvanen@google.com> wrote: > > > > The LLVM fix itself is trivial, and it looks like a pull request for > > it already exists. I assume we'll want to drop this flag for fixed > > LLVM versions when they're available. > > I will link it in the commit message when I pick it up soon -- already > did in https://github.com/Rust-for-Linux/linux/issues/1132. > > I also added the `-Z` flag to https://github.com/Rust-for-Linux/linux/issues/2. > > The `-Zmerge-functions` flag is internal but has been there since Rust > 1.34.0 in upstream commit: > > b91d211b4030 ("Add a target option "merge-functions" taking values > in ("disabled", "trampolines", or "aliases (the default)) to allow > targets to opt out of the MergeFunctions LLVM pass. Also add a > corresponding -Z option with the same name and values.") > > so that should be fine, but I will ping upstream Rust so that they are > aware we are using it. > > And, yeah, agreed, we probably should remove the flag conditionally > later on, to confirm the bug is gone etc. Function merging should also be disabled with gendwarfksyms. It causes faux::Registration::as_raw() and Page::as_ptr() to get merged, which incorrectly causes the former to get the CRC of the latter. Alice ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-11-17 20:58 ` Alice Ryhl @ 2026-11-17 22:03 ` Sami Tolvanen 2026-11-18 9:57 ` Alice Ryhl 2026-11-18 11:25 ` Gary Guo 1 sibling, 1 reply; 10+ messages in thread From: Sami Tolvanen @ 2026-11-17 22:03 UTC (permalink / raw) To: Alice Ryhl Cc: Miguel Ojeda, Gary Guo, Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Tue, Nov 17, 2026 at 12:58 PM Alice Ryhl <aliceryhl@google.com> wrote: > > Function merging should also be disabled with gendwarfksyms. It causes > faux::Registration::as_raw() and Page::as_ptr() to get merged, which > incorrectly causes the former to get the CRC of the latter. Sounds reasonable to me. Although, I assume this is only really a problem if the functions stop being merged later on, e.g. because they're no longer ABI compatible? Sami ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-11-17 22:03 ` Sami Tolvanen @ 2026-11-18 9:57 ` Alice Ryhl 0 siblings, 0 replies; 10+ messages in thread From: Alice Ryhl @ 2026-11-18 9:57 UTC (permalink / raw) To: Sami Tolvanen Cc: Miguel Ojeda, Gary Guo, Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Tue, Nov 17, 2026 at 11:03 PM Sami Tolvanen <samitolvanen@google.com> wrote: > > On Tue, Nov 17, 2026 at 12:58 PM Alice Ryhl <aliceryhl@google.com> wrote: > > > > Function merging should also be disabled with gendwarfksyms. It causes > > faux::Registration::as_raw() and Page::as_ptr() to get merged, which > > incorrectly causes the former to get the CRC of the latter. > > Sounds reasonable to me. Although, I assume this is only really a > problem if the functions stop being merged later on, e.g. because > they're no longer ABI compatible? They take pointers to different things, so the one that got merged definitely got the wrong CRC. They do not have the same signature. Alice ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-11-17 20:58 ` Alice Ryhl 2026-11-17 22:03 ` Sami Tolvanen @ 2026-11-18 11:25 ` Gary Guo 2026-11-18 11:52 ` Alice Ryhl 1 sibling, 1 reply; 10+ messages in thread From: Gary Guo @ 2026-11-18 11:25 UTC (permalink / raw) To: Alice Ryhl, Miguel Ojeda Cc: Sami Tolvanen, Gary Guo, Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Tue Nov 17, 2026 at 8:58 PM GMT, Alice Ryhl wrote: > On Fri, Aug 21, 2026 at 11:20:18AM +0200, Miguel Ojeda wrote: >> On Fri, Aug 21, 2026 at 1:43 AM Sami Tolvanen <samitolvanen@google.com> wrote: >> > >> > The LLVM fix itself is trivial, and it looks like a pull request for >> > it already exists. I assume we'll want to drop this flag for fixed >> > LLVM versions when they're available. >> >> I will link it in the commit message when I pick it up soon -- already >> did in https://github.com/Rust-for-Linux/linux/issues/1132. >> >> I also added the `-Z` flag to https://github.com/Rust-for-Linux/linux/issues/2. >> >> The `-Zmerge-functions` flag is internal but has been there since Rust >> 1.34.0 in upstream commit: >> >> b91d211b4030 ("Add a target option "merge-functions" taking values >> in ("disabled", "trampolines", or "aliases (the default)) to allow >> targets to opt out of the MergeFunctions LLVM pass. Also add a >> corresponding -Z option with the same name and values.") >> >> so that should be fine, but I will ping upstream Rust so that they are >> aware we are using it. >> >> And, yeah, agreed, we probably should remove the flag conditionally >> later on, to confirm the bug is gone etc. > > Function merging should also be disabled with gendwarfksyms. It causes > faux::Registration::as_raw() and Page::as_ptr() to get merged, which > incorrectly causes the former to get the CRC of the latter. Do we not want merging at all, or only when the types are not going to match up? If somehow the KCFI type metadata is always emitted, will two functions with the same KCFI type metadata be mergeable for gendwarfksyms purpose? Best, Gary ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-11-18 11:25 ` Gary Guo @ 2026-11-18 11:52 ` Alice Ryhl 0 siblings, 0 replies; 10+ messages in thread From: Alice Ryhl @ 2026-11-18 11:52 UTC (permalink / raw) To: Gary Guo Cc: Miguel Ojeda, Sami Tolvanen, Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Wed, Nov 18, 2026 at 12:25 PM Gary Guo <gary@garyguo.net> wrote: > > On Tue Nov 17, 2026 at 8:58 PM GMT, Alice Ryhl wrote: > > On Fri, Aug 21, 2026 at 11:20:18AM +0200, Miguel Ojeda wrote: > >> On Fri, Aug 21, 2026 at 1:43 AM Sami Tolvanen <samitolvanen@google.com> wrote: > >> > > >> > The LLVM fix itself is trivial, and it looks like a pull request for > >> > it already exists. I assume we'll want to drop this flag for fixed > >> > LLVM versions when they're available. > >> > >> I will link it in the commit message when I pick it up soon -- already > >> did in https://github.com/Rust-for-Linux/linux/issues/1132. > >> > >> I also added the `-Z` flag to https://github.com/Rust-for-Linux/linux/issues/2. > >> > >> The `-Zmerge-functions` flag is internal but has been there since Rust > >> 1.34.0 in upstream commit: > >> > >> b91d211b4030 ("Add a target option "merge-functions" taking values > >> in ("disabled", "trampolines", or "aliases (the default)) to allow > >> targets to opt out of the MergeFunctions LLVM pass. Also add a > >> corresponding -Z option with the same name and values.") > >> > >> so that should be fine, but I will ping upstream Rust so that they are > >> aware we are using it. > >> > >> And, yeah, agreed, we probably should remove the flag conditionally > >> later on, to confirm the bug is gone etc. > > > > Function merging should also be disabled with gendwarfksyms. It causes > > faux::Registration::as_raw() and Page::as_ptr() to get merged, which > > incorrectly causes the former to get the CRC of the latter. > > Do we not want merging at all, or only when the types are not going to match up? > If somehow the KCFI type metadata is always emitted, will two functions with the > same KCFI type metadata be mergeable for gendwarfksyms purpose? In principle merging would be ok if the gendwarfksyms CRCs are the same. I think that if KCFI hashes match, then the gendwarfksyms CRCs are quite likely to be the same too, but I don't think it's a hard guarantee. After all, for a pointer to struct argument, the KCFI hash depends only on the struct name, whereas gendwarfksym CRC also looks at its fields. Alice ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] rust: cfi: disable function merging if CFI is enabled 2026-08-20 13:57 [PATCH] rust: cfi: disable function merging if CFI is enabled Gary Guo 2026-08-20 15:58 ` Gary Guo @ 2026-08-24 1:15 ` Miguel Ojeda 1 sibling, 0 replies; 10+ messages in thread From: Miguel Ojeda @ 2026-08-24 1:15 UTC (permalink / raw) To: Gary Guo Cc: Nathan Chancellor, Nicolas Schier, Miguel Ojeda, Boqun Feng, Björn Roy Baron, Benno Lossin, Andreas Hindborg, Alice Ryhl, Trevor Gross, Danilo Krummrich, Daniel Almeida, Tamir Duberstein, Alexandre Courbot, Onur Özkan, Nick Desaulniers, Bill Wendling, Justin Stitt, kernel test robot, linux-kbuild, linux-kernel, rust-for-linux, llvm On Thu, Aug 20, 2026 at 3:57 PM Gary Guo <gary@kernel.org> wrote: > > From: Gary Guo <gary@garyguo.net> > > In Rust doc tests, there is a dummy `__module_firmware_test_init` function > generated by the example in `module_firmware!`'s documentation, which just > returns zero. Many other documentation generates function that produces > zero. LKP test robot reports a `Flags::zeroed` instance; my local > reproduction has a `Bounded::new::<0>`. > > LLVM's MergeFunctionsPass incorrectly merge functions with the same KCFI > type, causing `__module_firmware_test_init` being merged into one of the > zero-returning function. As module init is invoked via indirect function > call, KCFI is checked and this produces a KCFI failure. > > I've reported this bug to upstream LLVM [1]; in the mean time, disable > function merging if CFI is enabled. No separate treatment is needed for > CONFIG_RUST_INLINE_HELPERS, as Clang does not enable function merging by > default. > > Reported-by: kernel test robot <yi1.lai@intel.com> > Closes: https://lore.kernel.org/oe-lkp/202608201017.100a4511-lkp@intel.com > Link: https://github.com/llvm/llvm-project/issues/217629 [1] > Signed-off-by: Gary Guo <gary@garyguo.net> [ LLVM already has a pending PR: https://github.com/llvm/llvm-project/pull/217665 which solves the issue. In addition, I asked upstream Rust if the unstable `-Zmerge-functions=disabled` flag will remain around: https://rust-lang.zulipchat.com/#narrow/channel/425075-rust-for-linux/topic/.60-Zmerge-functions.3Ddisabled.60/ and it does indeed look like that will be the case. - Miguel ] [ Fixed typos as discussed. Reworded slightly for other typos. - Miguel ] Link: https://github.com/llvm/llvm-project/issues/217629 [2] Cc: stable@vger.kernel.org Fixes: ca627e636551 ("rust: cfi: add support for CFI_CLANG with Rust") Cheers, Miguel ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2026-11-18 11:52 UTC | newest] Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2026-08-20 13:57 [PATCH] rust: cfi: disable function merging if CFI is enabled Gary Guo 2026-08-20 15:58 ` Gary Guo 2026-08-20 23:42 ` Sami Tolvanen 2026-08-21 9:20 ` Miguel Ojeda 2026-11-17 20:58 ` Alice Ryhl 2026-11-17 22:03 ` Sami Tolvanen 2026-11-18 9:57 ` Alice Ryhl 2026-11-18 11:25 ` Gary Guo 2026-11-18 11:52 ` Alice Ryhl 2026-08-24 1:15 ` Miguel Ojeda
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®