mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Daniel Phillips <phillips@bonn-fries.net>
To: "Stephen C. Tweedie" <sct@redhat.com>
Cc: "Stephen C. Tweedie" <sct@redhat.com>,
	Chris Mason <mason@suse.com>,
	James Bottomley <James.Bottomley@steeleye.com>,
	linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org
Subject: Re: [PATCH] 2.4.x write barriers (updated for ext3)
Date: Mon, 4 Mar 2002 22:06:19 +0100	[thread overview]
Message-ID: <E16hzf1-0000fz-00@starship.berlin> (raw)
In-Reply-To: <phillips@bonn-fries.net> <E16hyRG-0000fO-00@starship.berlin> <20020304195723.J1444@redhat.com>
In-Reply-To: <20020304195723.J1444@redhat.com>

On March 4, 2002 08:57 pm, Stephen C. Tweedie wrote:
> Hi,
> 
> On Mon, Mar 04, 2002 at 08:48:02PM +0100, Daniel Phillips wrote:
> > On March 4, 2002 07:05 pm, Stephen C. Tweedie wrote:
> > > Also, as soon as we have journals on external devices, this whole
> > > thing changes entirely.  We still have to enforce the commit ordering
> > > in the journal, but we also still need the ordering between that
> > > commit and any subsequent writeback, and that obviousy can no longer
> > > be achieved via ordered tags if the two writes are happening on
> > > different devices.
> > 
> > But the bio layer can manage it, by sending a write barrier down all
> > relevant queues.  We can send a zero length write barrier command, yes?
> 
> Sort of --- there are various flush commands we can use.  However, bio
> can't just submit the barriers, it needs to synchronise them, and that
> means doing a global wait over all the devices until they have all
> acked their barrier op.  That's expensive: you may be as well off just
> using the current fs-internal synchronous commands at that point.

With ordered tags, at least we get the benefit of not having to wait on all 
the commands before the write barrier.

It's annoying to have to let the all the command queues empty, but it's hard 
to see what can be done about that, the synchronization *has* to be global.  
In this case, all we can do is to be sure to respond quickly to the command 
completion interrupt.  So the unavoidable cost is one request's worth of bus 
transfer (is there an advantage in trying to make it a small request?) and 
the latency of the interrupt.  100 uSec?

In the meantime, if I am right about being able to have multiple queues per 
disk, reads can continue.  It's not so bad.

The only way I can imagine of improving this is if there's a way to queue 
some commands on the understanding they're not to be carried out until the 
word is given.  My scsi-fu is not great enough to know if there's a way to do 
this.  Even if we could, it's probably not worth the effort, because all the 
drives will have to wait for the slowest/most loaded anyway.

That's life.

-- 
Daniel

  reply	other threads:[~2002-03-04 21:11 UTC|newest]

Thread overview: 73+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-02-22 15:57 James Bottomley
2002-02-22 16:10 ` Chris Mason
2002-02-22 16:13 ` Stephen C. Tweedie
2002-02-22 17:36   ` James Bottomley
2002-02-22 18:14     ` Chris Mason
2002-02-28 15:36       ` James Bottomley
2002-02-28 15:55         ` Chris Mason
2002-02-28 17:58           ` Mike Anderson
2002-02-28 18:12         ` Chris Mason
2002-03-01  2:08           ` James Bottomley
2002-03-03 22:11         ` Daniel Phillips
2002-03-04  4:21           ` Jeremy Higdon
2002-03-04  5:31             ` Daniel Phillips
2002-03-04  6:09               ` Jeremy Higdon
2002-03-04  7:57                 ` Daniel Phillips
2002-03-05  7:09                   ` Jeremy Higdon
2002-03-05 22:56                     ` Daniel Phillips
2002-03-04 16:52                 ` Stephen C. Tweedie
2002-03-04 18:15                   ` Daniel Phillips
2002-03-05  7:40                     ` Jens Axboe
2002-03-05 22:29                       ` Daniel Phillips
2002-03-12  7:01                         ` Jens Axboe
2002-03-10  5:24                   ` Douglas Gilbert
2002-03-11 11:13                     ` Kurt Garloff
2002-03-12  6:58                       ` Jens Axboe
2002-03-13 22:37                         ` Peter Osterlund
2002-03-11 11:34                     ` Stephen C. Tweedie
2002-03-11 17:15                       ` James Bottomley
2002-03-12  1:17                     ` GOTO Masanori
2002-03-04 14:48           ` James Bottomley
2002-03-06 13:59             ` Daniel Phillips
2002-03-06 14:34               ` James Bottomley
2002-03-04  3:34         ` Chris Mason
2002-03-04  5:05           ` Daniel Phillips
2002-03-04 15:03             ` James Bottomley
2002-03-04 17:04               ` Stephen C. Tweedie
2002-03-04 17:35                 ` James Bottomley
2002-03-04 17:48                   ` Chris Mason
2002-03-04 18:11                     ` James Bottomley
2002-03-04 18:41                       ` Chris Mason
2002-03-04 21:34                       ` Stephen C. Tweedie
2002-03-04 18:09                   ` Stephen C. Tweedie
2002-03-04 17:16               ` Chris Mason
2002-03-04 18:05                 ` Stephen C. Tweedie
2002-03-04 18:28                   ` James Bottomley
2002-03-04 19:55                     ` Stephen C. Tweedie
2002-03-04 19:48                   ` Daniel Phillips
2002-03-04 19:57                     ` Stephen C. Tweedie
2002-03-04 21:06                       ` Daniel Phillips [this message]
2002-03-05 14:58                         ` Stephen C. Tweedie
2002-03-05  7:48                     ` Jens Axboe
2002-03-04 19:51                 ` Daniel Phillips
2002-03-05  7:42                   ` Jens Axboe
2002-03-04  8:19           ` Helge Hafting
2002-03-04 14:57           ` James Bottomley
2002-03-04 17:24             ` Chris Mason
2002-03-04 19:02               ` Daniel Phillips
2002-03-05  7:22             ` Jeremy Higdon
2002-03-05 23:01               ` Daniel Phillips
2002-02-25 10:57 ` Helge Hafting
2002-02-25 15:04   ` James Bottomley
  -- strict thread matches above, loose matches on Subject: below --
2002-03-01 15:26 Dieter Nützel
2002-03-01 16:00 ` James Bottomley
2002-02-21 23:30 Chris Mason
2002-02-22 14:19 ` Stephen C. Tweedie
2002-02-22 15:26 ` Chris Mason
2002-01-10  9:55 [ANNOUNCE] FUSE: Filesystem in Userspace 0.95 Miklos Szeredi
2002-01-13  3:10 ` Pavel Machek
2002-01-21 10:18 ` Miklos Szeredi
2002-01-23 10:47   ` Pavel Machek
2002-01-22 19:07 ` Daniel Phillips
2002-01-23  2:33   ` [Avfs] " Justin Mason
2002-01-23  5:26     ` Daniel Phillips

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E16hzf1-0000fz-00@starship.berlin \
    --to=phillips@bonn-fries.net \
    --cc=James.Bottomley@steeleye.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-scsi@vger.kernel.org \
    --cc=mason@suse.com \
    --cc=sct@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®