Re: [PATCH] Submitting PROMISE IDE Controllers Driver Patch

[Alan Cox <alan@lxorguk.ukuu.org.uk>]

> Kernel Version: linux kernel 2.4.18

The big IDE update is going into 2.4.19pre. Thats going to overlap with this
patch I suspect. You might want to cross check with 2.4.19pre3 when it
appears and see how much you can remove.

> + * Support UltraDMA Mode 6 and 48 bit LBA Mode.
> + * Powered by PROMISE Technology, Inc. Portions Copyright (C)2001.
> + */
> +#define PCI_VENDOR_ID_PROMISE 0x105a

This define is already in pci_ids.h so shouldnt be needed here. Check the
file includes <linux/pci_ids.h>

>   /* Give size in megabytes (MB), not mebibytes (MiB). */
>   /* We compute the exact rounded value, avoiding overflow. */
> - printk (" (%ld MB)", (capacity - capacity/625 + 974)/1950);
> + printk (" (%ld GB)", ((capacity - capacity/625 + 974)/1950)/1024);

We use Mb for a reason (old disks look odd) - maybe using Gb once its >=
2Gb would work to make it look neater ?

>  {
> + if (HWIF(drive)->pci_devid.vid==0x105a)

elsewhere you switched to PCI_VENDOR_ID_PROMISE ? - trivial question

> -#define DEVID_PDC20268  ((ide_pci_devid_t){PCI_VENDOR_ID_PROMISE,
> PCI_DEVICE_ID_PROMISE_20268})
> -#define DEVID_PDC20268R ((ide_pci_devid_t){PCI_VENDOR_ID_PROMISE,
> PCI_DEVICE_ID_PROMISE_20268R})

You've removed the raid ones. The driver has to find those so that
the ataraid driver can then sit on top of them. 

Other than that it looks pretty sound. Your mailer seems to have messed
the tabs up so once 19pre3 appears and you've had a look at it can you
send me a copy as an attachment ?

Thanks
Alan