From: Rusty Russell <rusty@rustcorp.com.au>
To: torvalds@transmeta.com
Cc: linux-kernel@vger.kernel.org
Subject: [PATCH] Trivial: check_region cleanup from drivers/char/ip2main.c
Date: Mon, 27 May 2002 12:24:47 +1000 [thread overview]
Message-ID: <E17CABj-0001GY-00@wagner.rustcorp.com.au> (raw)
johnpol@2ka.mipt.ru: 40) request_region check, 31-40:
You say, i'm frezy :)
Please test and apply.
Evgeniy Polyakov ( s0mbre )
--- trivial-2.5.18/drivers/char/ip2main.c.orig Mon May 27 12:07:37 2002
+++ trivial-2.5.18/drivers/char/ip2main.c Mon May 27 12:07:37 2002
@@ -1002,12 +1002,10 @@
printk(KERN_INFO "IP2: Board %d: addr=0x%x irq=%d\n", boardnum + 1,
ip2config.addr[boardnum], ip2config.irq[boardnum] );
- if (0 != ( rc = check_region( ip2config.addr[boardnum], 8))) {
- printk(KERN_ERR "IP2: bad addr=0x%x rc = %d\n",
- ip2config.addr[boardnum], rc );
+ if (!request_region( ip2config.addr[boardnum], 8, pcName )) {
+ printk(KERN_ERR "IP2: bad addr=0x%x\n", ip2config.addr[boardnum]);
goto err_initialize;
}
- request_region( ip2config.addr[boardnum], 8, pcName );
if ( iiDownloadAll ( pB, (loadHdrStrPtr)Fip_firmware, 1, Fip_firmware_size )
!= II_DOWN_GOOD ) {
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
reply other threads:[~2002-05-27 2:21 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17CABj-0001GY-00@wagner.rustcorp.com.au \
--to=rusty@rustcorp.com.au \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®