* [PATCH] Trivial: check_region cleanup from drivers/char/ip2main.c
@ 2002-05-27 2:24 Rusty Russell
0 siblings, 0 replies; only message in thread
From: Rusty Russell @ 2002-05-27 2:24 UTC (permalink / raw)
To: torvalds; +Cc: linux-kernel
johnpol@2ka.mipt.ru: 40) request_region check, 31-40:
You say, i'm frezy :)
Please test and apply.
Evgeniy Polyakov ( s0mbre )
--- trivial-2.5.18/drivers/char/ip2main.c.orig Mon May 27 12:07:37 2002
+++ trivial-2.5.18/drivers/char/ip2main.c Mon May 27 12:07:37 2002
@@ -1002,12 +1002,10 @@
printk(KERN_INFO "IP2: Board %d: addr=0x%x irq=%d\n", boardnum + 1,
ip2config.addr[boardnum], ip2config.irq[boardnum] );
- if (0 != ( rc = check_region( ip2config.addr[boardnum], 8))) {
- printk(KERN_ERR "IP2: bad addr=0x%x rc = %d\n",
- ip2config.addr[boardnum], rc );
+ if (!request_region( ip2config.addr[boardnum], 8, pcName )) {
+ printk(KERN_ERR "IP2: bad addr=0x%x\n", ip2config.addr[boardnum]);
goto err_initialize;
}
- request_region( ip2config.addr[boardnum], 8, pcName );
if ( iiDownloadAll ( pB, (loadHdrStrPtr)Fip_firmware, 1, Fip_firmware_size )
!= II_DOWN_GOOD ) {
--
Anyone who quotes me in their sig is an idiot. -- Rusty Russell.
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2002-05-27 2:21 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-27 2:24 [PATCH] Trivial: check_region cleanup from drivers/char/ip2main.c Rusty Russell
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®