mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Rusty Russell <rusty@rustcorp.com.au>
To: Peter Chubb <peter@chubb.wattle.id.au>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH, TRIVIAL] Fix argument of BLKGETSIZE64
Date: Wed, 12 Jun 2002 15:41:23 +1000	[thread overview]
Message-ID: <E17I0sl-0004y0-00@wagner.rustcorp.com.au> (raw)
In-Reply-To: Your message of "Wed, 12 Jun 2002 15:02:00 +1000." <15622.54728.469214.307901@wombat.chubb.wattle.id.au>

In message <15622.54728.469214.307901@wombat.chubb.wattle.id.au> you write:
> 
> (2.5.21)  The third argument to BLKGETSIZE64 is declared as u64 in
> include/linux/fs.h
...
> -#define BLKGETSIZE64 _IOR(0x12,114,sizeof(u64))        /* 
> +#define BLKGETSIZE64 _IOR(0x12,114,sizeof(uint64_t))   /* 

This is a wider question: uint64_t and int64_t (et. al) are ISO C
<stdint.h> requirements.  Whether we should begin migration in 2.5, or
leave them alone is a Linus question.

> I think it should be uint64_t to allow glibc to copy and mangle the file into
> its header tree. 

I don't think that's really an issue, is it?
Rusty.
--
  Anyone who quotes me in their sig is an idiot. -- Rusty Russell.

  reply	other threads:[~2002-06-12  5:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-06-12  5:02 Peter Chubb
2002-06-12  5:41 ` Rusty Russell [this message]
2002-06-12 11:06   ` Peter Chubb
2002-06-12 13:22     ` Andreas Schwab
2002-06-12 13:47     ` David Woodhouse
2002-06-12 20:19       ` Peter Chubb
2002-06-12 20:45         ` David Woodhouse

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E17I0sl-0004y0-00@wagner.rustcorp.com.au \
    --to=rusty@rustcorp.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=peter@chubb.wattle.id.au \
    --cc=torvalds@transmeta.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®