From: Daniel Phillips <phillips@arcor.de>
To: Jesse Barnes <jbarnes@sgi.com>, Rik van Riel <riel@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, jmacd@namesys.com, rml@tech9.net
Subject: Re: [PATCH] lock assertion macros for 2.5.30
Date: Thu, 8 Aug 2002 00:30:10 +0200 [thread overview]
Message-ID: <E17cZJi-00050N-00@starship> (raw)
In-Reply-To: <20020807221532.GA20469@sgi.com>
A couple of whitespace glitches:
> +#if defined(CONFIG_DEBUG_SPINLOCK) && defined(CONFIG_SMP)
> +#define MUST_HOLD(lock) BUG_ON(!spin_is_locked(lock))
> +#define MUST_NOT_HOLD(lock) BUG_ON(spin_is_locked(lock))
> +#define MUST_HOLD_RW(lock) BUG_ON(!rwlock_is_locked(lock))
> +#else
> +#define MUST_HOLD(lock) do { } while(0)
> +#define MUST_NOT_HOLD(lock) do { } while(0)
> +#define MUST_HOLD_RW(lock) do { } while(0)
> +#endif /* CONFIG_DEBUG_SPINLOCK && CONFIG_SMP */
Random gripe: don't all those do { } whiles look silly? We need
#define NADA do { } while (0)
or similar.
--
Daniel
next prev parent reply other threads:[~2002-08-07 22:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-07 20:51 Jesse Barnes
2002-08-07 21:02 ` Rik van Riel
2002-08-07 21:08 ` Jesse Barnes
2002-08-07 21:21 ` Rik van Riel
2002-08-07 21:39 ` Jesse Barnes
2002-08-07 21:44 ` Rik van Riel
2002-08-08 7:58 ` Marcin Dalecki
2002-08-08 11:09 ` Daniel Phillips
2002-08-07 22:15 ` Jesse Barnes
2002-08-07 22:19 ` Rik van Riel
2002-08-08 17:23 ` Jesse Barnes
2002-08-08 17:36 ` Rik van Riel
2002-08-08 17:39 ` Jesse Barnes
2002-08-09 2:56 ` Daniel Phillips
2002-08-12 21:03 ` [PATCH] lock assertion macros for 2.5.31 Jesse Barnes
[not found] ` <3D5829B9.D281B855@zip.com.au>
[not found] ` <20020812223645.GB40343@sgi.com>
[not found] ` <3D5840E9.89C8680C@zip.com.au>
2002-08-21 18:26 ` Jesse Barnes
2002-08-21 18:40 ` Andrew Morton
2002-08-21 18:46 ` Jesse Barnes
2002-08-09 3:04 ` [PATCH] lock assertion macros for 2.5.30 Daniel Phillips
2002-08-09 4:12 ` Bernd Eckenfels
2002-08-07 22:30 ` Daniel Phillips [this message]
2002-08-07 22:41 ` Roman Zippel
2002-08-08 0:07 ` Thunder from the hill
2002-08-07 21:37 ` Oliver Xymoron
2002-08-08 12:55 ` Joshua MacDonald
2002-08-08 13:23 ` Jens Axboe
2002-08-08 6:00 ` Jens Axboe
2002-08-08 17:08 ` Jesse Barnes
2002-08-08 17:31 ` Rik van Riel
2002-08-08 17:35 ` Jesse Barnes
2002-08-08 17:43 ` Joshua MacDonald
2002-08-08 17:47 ` Rik van Riel
[not found] <0C01A29FBAE24448A792F5C68F5EA47D2D4437@nasdaq.ms.ensim.com>
2002-08-08 18:52 ` Paul Menage
2002-08-08 19:00 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17cZJi-00050N-00@starship \
--to=phillips@arcor.de \
--cc=jbarnes@sgi.com \
--cc=jmacd@namesys.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®