From: Paul Menage <pmenage@ensim.com>
To: Rik van Riel <riel@conectiva.com.br>
Cc: linux-kernel@vger.kernel.org, pmenage@ensim.com
Subject: Re: [PATCH] lock assertion macros for 2.5.30
Date: Thu, 08 Aug 2002 11:52:13 -0700 [thread overview]
Message-ID: <E17csOL-0008L7-00@pmenage-dt.ensim.com> (raw)
In-Reply-To: <0C01A29FBAE24448A792F5C68F5EA47D2D4437@nasdaq.ms.ensim.com>
In article <0C01A29FBAE24448A792F5C68F5EA47D2D4437@nasdaq.ms.ensim.com>,
you write:
>
>> Agreed. I'll post another patch that doesn't mess with the scsi
>> stuff. Maybe later I can put together a useful
>> 'lock-not-held-on-this-cpu' macro.
>
>You don't need to put this in a macro. This test is valid
>for ALL spinlocks in the kernel and can be done from inside
>the spin_lock() macro itself, when spinlock debugging is on.
>
There are some cases where this might not be true - e.g. in the
migration code in at least one version of the O(1) scheduler (included
in RedHat's 2.4.18-4) the migration_lock is taken on one CPU and
released on another (following an IPI being sent from the CPU that took
the lock).
So at the very least you'd need a separate set of spinlock primitives
that don't perform this test, which would have to be used by anyone
taking/releasing such a lock.
Paul
next parent reply other threads:[~2002-08-08 18:48 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <0C01A29FBAE24448A792F5C68F5EA47D2D4437@nasdaq.ms.ensim.com>
2002-08-08 18:52 ` Paul Menage [this message]
2002-08-08 19:00 ` Rik van Riel
2002-08-07 20:51 Jesse Barnes
2002-08-07 21:02 ` Rik van Riel
2002-08-07 21:08 ` Jesse Barnes
2002-08-07 21:21 ` Rik van Riel
2002-08-07 21:39 ` Jesse Barnes
2002-08-07 21:44 ` Rik van Riel
2002-08-08 7:58 ` Marcin Dalecki
2002-08-08 11:09 ` Daniel Phillips
2002-08-07 22:15 ` Jesse Barnes
2002-08-07 22:19 ` Rik van Riel
2002-08-08 17:23 ` Jesse Barnes
2002-08-08 17:36 ` Rik van Riel
2002-08-08 17:39 ` Jesse Barnes
2002-08-09 2:56 ` Daniel Phillips
2002-08-09 3:04 ` Daniel Phillips
2002-08-09 4:12 ` Bernd Eckenfels
2002-08-07 22:30 ` Daniel Phillips
2002-08-07 22:41 ` Roman Zippel
2002-08-08 0:07 ` Thunder from the hill
2002-08-07 21:37 ` Oliver Xymoron
2002-08-08 12:55 ` Joshua MacDonald
2002-08-08 13:23 ` Jens Axboe
2002-08-08 6:00 ` Jens Axboe
2002-08-08 17:08 ` Jesse Barnes
2002-08-08 17:31 ` Rik van Riel
2002-08-08 17:35 ` Jesse Barnes
2002-08-08 17:43 ` Joshua MacDonald
2002-08-08 17:47 ` Rik van Riel
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E17csOL-0008L7-00@pmenage-dt.ensim.com \
--to=pmenage@ensim.com \
--cc=linux-kernel@vger.kernel.org \
--cc=riel@conectiva.com.br \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®