From: davej@redhat.com
To: linux-kernel@vger.kernel.org
Cc: torvalds@osdl.org, akpm@osdl.org
Subject: logic error in aty128fb
Date: Fri, 23 Jan 2004 06:35:25 +0000 [thread overview]
Message-ID: <E1Ajuub-0000xm-00@hardwired> (raw)
Negate the expression not the register seems more sensible?
Dave
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/aty/aty128fb.c linux-2.5/drivers/video/aty/aty128fb.c
--- bk-linus/drivers/video/aty/aty128fb.c 2003-10-15 05:00:42.000000000 +0100
+++ linux-2.5/drivers/video/aty/aty128fb.c 2004-01-14 07:07:10.000000000 +0000
@@ -2102,7 +2102,7 @@ aty128_set_backlight_enable(int on, int
reg |= LVDS_BL_MOD_EN | LVDS_BLON;
if (on && level > BACKLIGHT_OFF) {
reg |= LVDS_DIGION;
- if (!reg & LVDS_ON) {
+ if (!(reg & LVDS_ON)) {
reg &= ~LVDS_BLON;
aty_st_le32(LVDS_GEN_CNTL, reg);
(void)aty_ld_le32(LVDS_GEN_CNTL);
reply other threads:[~2004-01-23 6:38 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1Ajuub-0000xm-00@hardwired \
--to=davej@redhat.com \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@osdl.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®