* logic error in aty128fb
@ 2004-01-23 6:35 davej
0 siblings, 0 replies; only message in thread
From: davej @ 2004-01-23 6:35 UTC (permalink / raw)
To: linux-kernel; +Cc: torvalds, akpm
Negate the expression not the register seems more sensible?
Dave
diff -urpN --exclude-from=/home/davej/.exclude bk-linus/drivers/video/aty/aty128fb.c linux-2.5/drivers/video/aty/aty128fb.c
--- bk-linus/drivers/video/aty/aty128fb.c 2003-10-15 05:00:42.000000000 +0100
+++ linux-2.5/drivers/video/aty/aty128fb.c 2004-01-14 07:07:10.000000000 +0000
@@ -2102,7 +2102,7 @@ aty128_set_backlight_enable(int on, int
reg |= LVDS_BL_MOD_EN | LVDS_BLON;
if (on && level > BACKLIGHT_OFF) {
reg |= LVDS_DIGION;
- if (!reg & LVDS_ON) {
+ if (!(reg & LVDS_ON)) {
reg &= ~LVDS_BLON;
aty_st_le32(LVDS_GEN_CNTL, reg);
(void)aty_ld_le32(LVDS_GEN_CNTL);
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2004-01-23 6:38 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-01-23 6:35 logic error in aty128fb davej
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®