From: janitor@sternwelten.at
To: linux-kernel@vger.kernel.org
Cc: akpm@digeo.com, janitor@sternwelten.at
Subject: [patch 20/25] ec3104: replace schedule_timeout() with msleep()
Date: Wed, 01 Sep 2004 22:57:28 +0200 [thread overview]
Message-ID: <E1C2cAa-0007TW-JF@sputnik> (raw)
I would appreciate any comments from the janitor@sternweltens list. This is one (of
a few) places where I had to make a decision to set the state before the
call to
schedule_timeout();
This of course affected any decision to replace the code with msleep()
or not. Please inform if the other state from the one I used is desired.
Thanks,
Nish
Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.
Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>
---
linux-2.6.9-rc1-bk7-max/drivers/char/ec3104_keyb.c | 2 +-
1 files changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/char/ec3104_keyb.c~msleep-drivers_char_ec3104_keyb drivers/char/ec3104_keyb.c
--- linux-2.6.9-rc1-bk7/drivers/char/ec3104_keyb.c~msleep-drivers_char_ec3104_keyb 2004-09-01 19:34:45.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/char/ec3104_keyb.c 2004-09-01 19:34:45.000000000 +0200
@@ -412,7 +412,7 @@ static void ec3104_keyb_clear_state(void
k->last_msr = 0;
for (;;) {
- schedule_timeout(HZ/10);
+ msleep(100);
msr = ctrl_inb(EC3104_SER4_MSR);
_
reply other threads:[~2004-09-01 23:00 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1C2cAa-0007TW-JF@sputnik \
--to=janitor@sternwelten.at \
--cc=akpm@digeo.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®