mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [patch 20/25]  ec3104: replace schedule_timeout() with  msleep()
@ 2004-09-01 20:57 janitor
  0 siblings, 0 replies; only message in thread
From: janitor @ 2004-09-01 20:57 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm, janitor







I would appreciate any comments from the janitor@sternweltens list. This is one (of
a few) places where I had to make a decision to set the state before the
call to

schedule_timeout();

This of course affected any decision to replace the code with msleep()
or not. Please inform if the other state from the one I used is desired.

Thanks,
Nish



Description: Uses msleep() instead of schedule_timeout() to guarantee
the task delays at least the desired time amount.

Signed-off-by: Nishanth Aravamudan <nacc@us.ibm.com>
Signed-off-by: Maximilian Attems <janitor@sternwelten.at>



---

 linux-2.6.9-rc1-bk7-max/drivers/char/ec3104_keyb.c |    2 +-
 1 files changed, 1 insertion(+), 1 deletion(-)

diff -puN drivers/char/ec3104_keyb.c~msleep-drivers_char_ec3104_keyb drivers/char/ec3104_keyb.c
--- linux-2.6.9-rc1-bk7/drivers/char/ec3104_keyb.c~msleep-drivers_char_ec3104_keyb	2004-09-01 19:34:45.000000000 +0200
+++ linux-2.6.9-rc1-bk7-max/drivers/char/ec3104_keyb.c	2004-09-01 19:34:45.000000000 +0200
@@ -412,7 +412,7 @@ static void ec3104_keyb_clear_state(void
 	k->last_msr = 0;
 
 	for (;;) {
-		schedule_timeout(HZ/10);
+		msleep(100);
 
 		msr = ctrl_inb(EC3104_SER4_MSR);
 	

_

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-09-01 23:00 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2004-09-01 20:57 [patch 20/25] ec3104: replace schedule_timeout() with msleep() janitor

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®