* [PATCH] Fix comments in 8250.c
@ 2005-04-11 22:15 Russell King
0 siblings, 0 replies; only message in thread
From: Russell King @ 2005-04-11 22:15 UTC (permalink / raw)
To: Andrew Morton; +Cc: LKML
Fix the formatting of some comments in 8250.c, and add a note
that the register_serial / unregister_serial shouldn't be used
in new code.
We do this here in preference to adding to linux/serial.h, since
that is used by a number of non-8250 drivers which pretend to be
8250. It is not known whether it would be appropriate to do so.
Signed-off-by: Russell King <rmk@arm.linux.org.uk>
diff -up -x BitKeeper -x ChangeSet -x SCCS -x _xlk -x '*.orig' -x '*.rej' -r orig/drivers/serial/8250.c linux/drivers/serial/8250.c
--- orig/drivers/serial/8250.c Mon Apr 4 22:54:05 2005
+++ linux/drivers/serial/8250.c Mon Apr 11 20:41:22 2005
@@ -1065,8 +1065,10 @@ receive_chars(struct uart_8250_port *up,
tty_flip_buffer_push(tty);
spin_lock(&up->port.lock);
}
- /* If this failed then we will throw away the
- bytes but must do so to clear interrupts */
+ /*
+ * If this failed then we will throw away the
+ * bytes but must do so to clear interrupts
+ */
}
ch = serial_inp(up, UART_RX);
flag = TTY_NORMAL;
@@ -1106,7 +1108,7 @@ receive_chars(struct uart_8250_port *up,
up->port.icount.overrun++;
/*
- * Mask off conditions which should be ingored.
+ * Mask off conditions which should be ignored.
*/
lsr &= up->port.read_status_mask;
@@ -2570,6 +2572,9 @@ MODULE_ALIAS_CHARDEV_MAJOR(TTY_MAJOR);
* If this fails an error is returned.
*
* On success the port is ready to use and the line number is returned.
+ *
+ * Note: this function is deprecated - use serial8250_register_port
+ * instead.
*/
int register_serial(struct serial_struct *req)
{
@@ -2624,6 +2629,9 @@ EXPORT_SYMBOL(register_serial);
*
* Remove one serial port. This may not be called from interrupt
* context. We hand the port back to our local PM control.
+ *
+ * Note: this function is deprecated - use serial8250_unregister_port
+ * instead.
*/
void unregister_serial(int line)
{
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2005-04-11 22:18 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-04-11 22:15 [PATCH] Fix comments in 8250.c Russell King
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®