From: Al Viro <viro@www.linux.org.uk>
To: linux-kernel@vger.kernel.org
Cc: akpm@osdl.org
Subject: [CFR][PATCH] namei fixes (8/19)
Date: Thu, 19 May 2005 23:56:41 +0100 [thread overview]
Message-ID: <E1DYtwX-0007rg-7k@parcelfarce.linux.theplanet.co.uk> (raw)
(8/19)
In open_namei() we never use path.mnt or path.dentry after exit: or ok:.
Assignment of path.dentry in case of LAST_BIND is dead code and only
obfuscates already convoluted function; assignment of path.mnt after
__do_follow_link() can be moved down to the place where we set path.dentry.
Obviously equivalent transformations, just to clean the air a bit in that
region.
Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
----
diff -urN RC12-rc4-7/fs/namei.c RC12-rc4-8/fs/namei.c
--- RC12-rc4-7/fs/namei.c 2005-05-19 16:39:35.831363809 -0400
+++ RC12-rc4-8/fs/namei.c 2005-05-19 16:39:36.950140877 -0400
@@ -1526,14 +1526,11 @@
if (error)
goto exit_dput;
error = __do_follow_link(&path, nd);
- path.mnt = nd->mnt;
if (error)
return error;
nd->flags &= ~LOOKUP_PARENT;
- if (nd->last_type == LAST_BIND) {
- path.dentry = nd->dentry;
+ if (nd->last_type == LAST_BIND)
goto ok;
- }
error = -EISDIR;
if (nd->last_type != LAST_NORM)
goto exit;
@@ -1549,6 +1546,7 @@
dir = nd->dentry;
down(&dir->d_inode->i_sem);
path.dentry = __lookup_hash(&nd->last, nd->dentry, nd);
+ path.mnt = nd->mnt;
putname(nd->last.name);
goto do_last;
}
reply other threads:[~2005-05-19 23:26 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E1DYtwX-0007rg-7k@parcelfarce.linux.theplanet.co.uk \
--to=viro@www.linux.org.uk \
--cc=akpm@osdl.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®