mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [CFR][PATCH] namei fixes (8/19)
@ 2005-05-19 22:56 Al Viro
  0 siblings, 0 replies; only message in thread
From: Al Viro @ 2005-05-19 22:56 UTC (permalink / raw)
  To: linux-kernel; +Cc: akpm

(8/19)

In open_namei() we never use path.mnt or path.dentry after exit: or ok:.
Assignment of path.dentry in case of LAST_BIND is dead code and only
obfuscates already convoluted function; assignment of path.mnt after
__do_follow_link() can be moved down to the place where we set path.dentry.

Obviously equivalent transformations, just to clean the air a bit in that
region.

Signed-off-by: Al Viro <viro@parcelfarce.linux.theplanet.co.uk>
----
diff -urN RC12-rc4-7/fs/namei.c RC12-rc4-8/fs/namei.c
--- RC12-rc4-7/fs/namei.c	2005-05-19 16:39:35.831363809 -0400
+++ RC12-rc4-8/fs/namei.c	2005-05-19 16:39:36.950140877 -0400
@@ -1526,14 +1526,11 @@
 	if (error)
 		goto exit_dput;
 	error = __do_follow_link(&path, nd);
-	path.mnt = nd->mnt;
 	if (error)
 		return error;
 	nd->flags &= ~LOOKUP_PARENT;
-	if (nd->last_type == LAST_BIND) {
-		path.dentry = nd->dentry;
+	if (nd->last_type == LAST_BIND)
 		goto ok;
-	}
 	error = -EISDIR;
 	if (nd->last_type != LAST_NORM)
 		goto exit;
@@ -1549,6 +1546,7 @@
 	dir = nd->dentry;
 	down(&dir->d_inode->i_sem);
 	path.dentry = __lookup_hash(&nd->last, nd->dentry, nd);
+	path.mnt = nd->mnt;
 	putname(nd->last.name);
 	goto do_last;
 }

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2005-05-19 23:26 UTC | newest]

Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2005-05-19 22:56 [CFR][PATCH] namei fixes (8/19) Al Viro

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®