mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Sanjoy Mahajan <sanjoy@mrao.cam.ac.uk>
To: "Yu, Luming" <luming.yu@intel.com>
Cc: linux-kernel@vger.kernel.org,
	"Linus Torvalds" <torvalds@osdl.org>,
	"Andrew Morton" <akpm@osdl.org>,
	"Tom Seeley" <redhat@tomseeley.co.uk>,
	"Dave Jones" <davej@redhat.com>,
	"Jiri Slaby" <jirislaby@gmail.com>,
	michael@mihu.de, mchehab@infradead.org,
	v4l-dvb-maintainer@linuxtv.org, video4linux-list@redhat.com,
	"Brian Marete" <bgmarete@gmail.com>,
	"Ryan Phillips" <rphillips@gentoo.org>,
	gregkh@suse.de, linux-usb-devel@lists.sourceforge.net, "Brown,
	Len" <len.brown@intel.com>,
	linux-acpi@vger.kernel.org, "Mark Lord" <lkml@rtr.ca>,
	"Randy Dunlap" <rdunlap@xenotime.net>,
	jgarzik@pobox.com, linux-ide@vger.kernel.org,
	"Duncan" <1i5t5.duncan@cox.net>,
	"Pavlik Vojtech" <vojtech@suse.cz>,
	linux-input@atrey.karlin.mff.cuni.cz,
	"Meelis Roos" <mroos@linux.ee>
Subject: Re: 2.6.16-rc5: known regressions [600X S3 sleep]
Date: Fri, 03 Mar 2006 05:58:50 +0000	[thread overview]
Message-ID: <E1FF3JS-0003qn-00@skye.ra.phy.cam.ac.uk> (raw)
In-Reply-To: Your message of "Fri, 03 Mar 2006 12:46:06 +0800." <3ACA40606221794F80A5670F0AF15F840B172CC2@pdsmsx403>

>>>> Subject    : S3 sleep hangs the second time - 600X
>>>> References : http://bugzilla.kernel.org/show_bug.cgi?id=5989

>>From: "Yu, Luming" <luming.yu@intel.com>
>>> According to bug report, the BIOS DSDT is modified.  I don't know
>>> how these changes affect the results of suspend/resume. But, it is
>>> clear this is NOT right approach to fix problem. Hence, I need the
>>> testing report with un-modified DSDT on TP 600X, bios 1.11.

>>I'll try it, although I don't think I'll get any data on the problem.
>>The unmodified DSDT (bios 1.11) lacks an S3 sleep object, so I had to
>>modify the DSDT even to get S3 to sleep at all.  See
>><http://bugzilla.kernel.org/show_bug.cgi?id=3534> for that discussion.

I just tried the first failing commit
(02b28a33aae93a3b53068e0858d62f8bcaef60a3):

Author: Len Brown <len.brown@intel.com>
Date:   Mon Dec 5 16:46:36 2005 -0500

    [ACPI] Enable Embedded Controller (EC) interrupt mode by default
    
    "ec_intr=0" reverts to polling
    "ec_burst=" no longer exists.
    
    Signed-off-by: Len Brown <len.brown@intel.com>
    Acked-by: Luming Yu <luming.yu@intel.com>

but with the vanilla (BIOS 1.11) DSDT.  And not only did S3 sleep
happen, but the thermal+processor bug didn't show up: i.e. it did two
(actually) many S3 sleep-wake cycles.  So the problem is due to
something in the modified DSDT, which is either a problem itself or it
exposes another problem.

[Picture of me hanging head in shame for putting people to the trouble.]

My only excuse is that long ago (2.6.11), the machine wouldn't S3
sleep at all with the vanilla DSDT, and I patched it as recommended by
the ACPI experts.  However, the current ACPI interpreter seems to
handle the 600X's mangy DSDT.

Now I agree 100% with Len Brown that it's best to have ACPI handle
marginal DSDT's, not hack the DSDT.

-Sanjoy

`Never underestimate the evil of which men of power are capable.'
         --Bertrand Russell, _War Crimes in Vietnam_, chapter 1.

      reply	other threads:[~2006-03-03  5:58 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-03-03  4:46 2.6.16-rc5: known regressions Yu, Luming
2006-03-03  5:58 ` Sanjoy Mahajan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1FF3JS-0003qn-00@skye.ra.phy.cam.ac.uk \
    --to=sanjoy@mrao.cam.ac.uk \
    --cc=1i5t5.duncan@cox.net \
    --cc=akpm@osdl.org \
    --cc=bgmarete@gmail.com \
    --cc=davej@redhat.com \
    --cc=gregkh@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=jirislaby@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-input@atrey.karlin.mff.cuni.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb-devel@lists.sourceforge.net \
    --cc=lkml@rtr.ca \
    --cc=luming.yu@intel.com \
    --cc=mchehab@infradead.org \
    --cc=michael@mihu.de \
    --cc=mroos@linux.ee \
    --cc=rdunlap@xenotime.net \
    --cc=redhat@tomseeley.co.uk \
    --cc=rphillips@gentoo.org \
    --cc=torvalds@osdl.org \
    --cc=v4l-dvb-maintainer@linuxtv.org \
    --cc=video4linux-list@redhat.com \
    --cc=vojtech@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®