* RE: 2.6.16-rc5: known regressions
@ 2006-03-03 4:46 Yu, Luming
2006-03-03 5:58 ` 2.6.16-rc5: known regressions [600X S3 sleep] Sanjoy Mahajan
0 siblings, 1 reply; 2+ messages in thread
From: Yu, Luming @ 2006-03-03 4:46 UTC (permalink / raw)
To: Sanjoy Mahajan
Cc: linux-kernel, Linus Torvalds, Andrew Morton, Tom Seeley,
Dave Jones, Jiri Slaby, michael, mchehab, v4l-dvb-maintainer,
video4linux-list, Brian Marete, Ryan Phillips, gregkh,
linux-usb-devel, Brown, Len, linux-acpi, Mark Lord, Randy Dunlap,
jgarzik, linux-ide, Duncan, Pavlik Vojtech, linux-input,
Meelis Roos
>
>>> Subject : S3 sleep hangs the second time - 600X
>>> References : http://bugzilla.kernel.org/show_bug.cgi?id=5989
>
>From: "Yu, Luming" <luming.yu@intel.com>
>> According to bug report, the BIOS DSDT is modified. I don't know
>> how these changes affect the results of suspend/resume. But, it is
>> clear this is NOT right approach to fix problem. Hence, I need the
>> testing report with un-modified DSDT on TP 600X, bios 1.11.
>
>I'll try it, although I don't think I'll get any data on the problem.
>The unmodified DSDT (bios 1.11) lacks an S3 sleep object, so I had to
>modify the DSDT even to get S3 to sleep at all. See
><http://bugzilla.kernel.org/show_bug.cgi?id=3534> for that discussion.
>In additional comment #4 there (2004-10-14), you said:
>
> The root cause of [the missing S3 object] failure is that linux is
> using element in
>
> const char *acpi_gbl_sleep_state_names[ACPI_S_STATE_COUNT] =
> {
> "\_S0_",
> "\_S1_",
> "\_S2_",
> "\_S3_",
> "\_S4_",
> "\_S5_"
> };
>
> to call acpi_get_sleep_type_data, but your box define _S3 under the
> device PNP0A03. So, the evaluating \_S3 will fail.
>
> The workaround in DSDT is to change _S3 to \_S3_ .
> We can fix it in acpi driver soon.
Hmm, this conclusion seems to be wrong. at that time, I said it too
early. The real problem is this, if your box support S3, the _S3 method
should return from ELSE-statement which return package
{0x01,0x01,0x00,0x00}.
If you still use this
http://bugzilla.kernel.org/show_bug.cgi?id=3534#c10 to
override your DSDT, which bypass the testing and blindly assume BIOS or
platform
do support S3, then I suggest you to retest, and post dmesg with
UN-modified BIOS.
Thanks,
Luming
Method (_S3, 0, NotSerialized)
{
If (BXPT)
{
Return (Package (0x04)
{
0x06,
0x06,
0x00,
0x00
})
}
Else
{
Return (Package (0x04)
{
0x01,
0x01,
0x00,
0x00
})
}
}
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: 2.6.16-rc5: known regressions [600X S3 sleep]
2006-03-03 4:46 2.6.16-rc5: known regressions Yu, Luming
@ 2006-03-03 5:58 ` Sanjoy Mahajan
0 siblings, 0 replies; 2+ messages in thread
From: Sanjoy Mahajan @ 2006-03-03 5:58 UTC (permalink / raw)
To: Yu, Luming
Cc: linux-kernel, Linus Torvalds, Andrew Morton, Tom Seeley,
Dave Jones, Jiri Slaby, michael, mchehab, v4l-dvb-maintainer,
video4linux-list, Brian Marete, Ryan Phillips, gregkh,
linux-usb-devel, Brown, Len, linux-acpi, Mark Lord, Randy Dunlap,
jgarzik, linux-ide, Duncan, Pavlik Vojtech, linux-input,
Meelis Roos
>>>> Subject : S3 sleep hangs the second time - 600X
>>>> References : http://bugzilla.kernel.org/show_bug.cgi?id=5989
>>From: "Yu, Luming" <luming.yu@intel.com>
>>> According to bug report, the BIOS DSDT is modified. I don't know
>>> how these changes affect the results of suspend/resume. But, it is
>>> clear this is NOT right approach to fix problem. Hence, I need the
>>> testing report with un-modified DSDT on TP 600X, bios 1.11.
>>I'll try it, although I don't think I'll get any data on the problem.
>>The unmodified DSDT (bios 1.11) lacks an S3 sleep object, so I had to
>>modify the DSDT even to get S3 to sleep at all. See
>><http://bugzilla.kernel.org/show_bug.cgi?id=3534> for that discussion.
I just tried the first failing commit
(02b28a33aae93a3b53068e0858d62f8bcaef60a3):
Author: Len Brown <len.brown@intel.com>
Date: Mon Dec 5 16:46:36 2005 -0500
[ACPI] Enable Embedded Controller (EC) interrupt mode by default
"ec_intr=0" reverts to polling
"ec_burst=" no longer exists.
Signed-off-by: Len Brown <len.brown@intel.com>
Acked-by: Luming Yu <luming.yu@intel.com>
but with the vanilla (BIOS 1.11) DSDT. And not only did S3 sleep
happen, but the thermal+processor bug didn't show up: i.e. it did two
(actually) many S3 sleep-wake cycles. So the problem is due to
something in the modified DSDT, which is either a problem itself or it
exposes another problem.
[Picture of me hanging head in shame for putting people to the trouble.]
My only excuse is that long ago (2.6.11), the machine wouldn't S3
sleep at all with the vanilla DSDT, and I patched it as recommended by
the ACPI experts. However, the current ACPI interpreter seems to
handle the 600X's mangy DSDT.
Now I agree 100% with Len Brown that it's best to have ACPI handle
marginal DSDT's, not hack the DSDT.
-Sanjoy
`Never underestimate the evil of which men of power are capable.'
--Bertrand Russell, _War Crimes in Vietnam_, chapter 1.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2006-03-03 5:58 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2006-03-03 4:46 2.6.16-rc5: known regressions Yu, Luming
2006-03-03 5:58 ` 2.6.16-rc5: known regressions [600X S3 sleep] Sanjoy Mahajan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®