mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Bodo Eggert <7eggert@gmx.de>
To: Kamalesh Babulal <kamalesh@linux.vnet.ibm.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Benjamin Herrenschmidt <benh@ozlabs.org>,
	linux-kernel@vger.kernel.org,
	Linus Torvalds <torvalds@linux-foundation.org>
Subject: Re: [PATCH] init()/fini() clean up in the crypto
Date: Thu, 27 Mar 2008 15:40:36 +0100	[thread overview]
Message-ID: <E1JetHQ-0000wK-Mk@be1.7eggert.dyndns.org> (raw)
In-Reply-To: <abVvc-4cT-5@gated-at.bofh.it>

Kamalesh Babulal <kamalesh@linux.vnet.ibm.com> wrote:

> This patch cleanups the crypto code, replaces the init() and fini()  with the
> <algorithm name>_init/_fini

This part ist OK.

> or init/fini_<algorithm name> (if the 
> <algorithm name>_init/_fini exist)

Having init_foo and foo_init won't be a good thing, will it? I'd start
confusing them.

What about foo_modinit instead?

¢¢


       reply	other threads:[~2008-03-27 14:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <abRrB-4uZ-1@gated-at.bofh.it>
     [not found] ` <abRBc-53a-9@gated-at.bofh.it>
     [not found]   ` <abVvc-4cT-5@gated-at.bofh.it>
2008-03-27 14:40     ` Bodo Eggert [this message]
2008-03-27 17:32       ` [RESENDING-PATCH] " Kamalesh Babulal
2008-04-05 13:02         ` Herbert Xu
2008-03-27  3:52 [PATCH] Give futex init a proper name Benjamin Herrenschmidt
2008-03-27  4:00 ` Andrew Morton
2008-03-27  8:12   ` [PATCH] init()/fini() clean up in the crypto Kamalesh Babulal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1JetHQ-0000wK-Mk@be1.7eggert.dyndns.org \
    --to=7eggert@gmx.de \
    --cc=akpm@linux-foundation.org \
    --cc=benh@ozlabs.org \
    --cc=kamalesh@linux.vnet.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®