mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Herbert Xu <herbert@gondor.hengli.com.au>
To: David Miller <davem@davemloft.net>,
	eric.dumazet@gmail.com, evonlanthen@gmail.com,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	timo.teras@iki.fi
Subject: [PATCH 4/6] net: Remove LL_ALLOCATED_SPACE
Date: Fri, 18 Nov 2011 20:20:05 +0800	[thread overview]
Message-ID: <E1RRNQL-0000lW-3F@gondolin.me.apana.org.au> (raw)
In-Reply-To: <20111118121832.GA2868@gondor.apana.org.au>

net: Remove LL_ALLOCATED_SPACE

The macro LL_ALLOCATED_SPACE was ill-conceived.  It applies the
alignment to the sum of needed_headroom and needed_tailroom.  As
the amount that is then reserved for head room is needed_headroom
with alignment, this means that the tail room left may be too small.

Now that all uses of LL_ALLOCATED_SPACE have been removed, this
patch finally removes the macro itself.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
---

 include/linux/netdevice.h |    5 -----
 1 file changed, 5 deletions(-)

diff --git a/include/linux/netdevice.h b/include/linux/netdevice.h
index cbeb586..1568c9d 100644
--- a/include/linux/netdevice.h
+++ b/include/linux/netdevice.h
@@ -272,16 +272,11 @@ struct hh_cache {
  *
  * We could use other alignment values, but we must maintain the
  * relationship HH alignment <= LL alignment.
- *
- * LL_ALLOCATED_SPACE also takes into account the tailroom the device
- * may need.
  */
 #define LL_RESERVED_SPACE(dev) \
 	((((dev)->hard_header_len+(dev)->needed_headroom)&~(HH_DATA_MOD - 1)) + HH_DATA_MOD)
 #define LL_RESERVED_SPACE_EXTRA(dev,extra) \
 	((((dev)->hard_header_len+(dev)->needed_headroom+(extra))&~(HH_DATA_MOD - 1)) + HH_DATA_MOD)
-#define LL_ALLOCATED_SPACE(dev) \
-	((((dev)->hard_header_len+(dev)->needed_headroom+(dev)->needed_tailroom)&~(HH_DATA_MOD - 1)) + HH_DATA_MOD)
 
 struct header_ops {
 	int	(*create) (struct sk_buff *skb, struct net_device *dev,

  parent reply	other threads:[~2011-11-18 12:20 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-14  8:08 PROBLEM: System call 'sendmsg' of process ospfd (quagga) causes kernel oops Elmar Vonlanthen
2011-10-14 14:57 ` Eric Dumazet
2011-10-17  7:16   ` Elmar Vonlanthen
2011-10-18  2:30     ` Eric Dumazet
2011-10-18  9:34       ` Herbert Xu
2011-10-18 10:01         ` Eric Dumazet
2011-10-18 10:05           ` Herbert Xu
2011-10-18 10:23             ` Eric Dumazet
2011-10-18 10:45               ` Herbert Xu
2011-10-18 11:37                 ` Eric Dumazet
2011-10-18 11:49                   ` Herbert Xu
2011-10-18 12:56                     ` Eric Dumazet
2011-10-18 13:45                       ` Herbert Xu
2011-10-19  7:09                         ` David Miller
2011-10-19  7:18                           ` Eric Dumazet
2011-10-19  7:30                             ` David Miller
2011-10-19  7:52                               ` Eric Dumazet
2011-10-19  8:02                                 ` David Miller
2011-10-19  8:08                               ` Herbert Xu
2011-10-20  9:30                                 ` David Miller
2011-10-20  9:35                                   ` Herbert Xu
2011-10-20 20:21                                     ` David Miller
2011-10-25 11:54                                     ` Herbert Xu
2011-10-26  3:12                                       ` David Miller
2011-11-18 12:18                                         ` [0/6] Replace LL_ALLOCATED_SPACE to allow needed_headroom adjustment Herbert Xu
2011-11-18 12:20                                           ` [PATCH 2/6] ipv6: Remove all uses of LL_ALLOCATED_SPACE Herbert Xu
2011-11-18 12:20                                           ` [PATCH 1/6] ipv4: " Herbert Xu
2011-11-18 12:20                                           ` [PATCH 3/6] net: " Herbert Xu
2011-11-18 12:20                                           ` Herbert Xu [this message]
2011-11-18 12:20                                           ` [PATCH 5/6] packet: Add needed_tailroom to packet_sendmsg_spkt Herbert Xu
2011-11-18 12:20                                           ` [PATCH 6/6] ip_gre: Set needed_headroom dynamically again Herbert Xu
2011-11-18 20:01                                           ` [0/6] Replace LL_ALLOCATED_SPACE to allow needed_headroom adjustment David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=E1RRNQL-0000lW-3F@gondolin.me.apana.org.au \
    --to=herbert@gondor.hengli.com.au \
    --cc=davem@davemloft.net \
    --cc=eric.dumazet@gmail.com \
    --cc=evonlanthen@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=timo.teras@iki.fi \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®