From: Herbert Xu <herbert@gondor.hengli.com.au>
To: Eric Dumazet <eric.dumazet@gmail.com>
Cc: "Elmar Vonlanthen" <evonlanthen@gmail.com>,
linux-kernel@vger.kernel.org, netdev <netdev@vger.kernel.org>,
"Timo Teräs" <timo.teras@iki.fi>
Subject: Re: PROBLEM: System call 'sendmsg' of process ospfd (quagga) causes kernel oops
Date: Tue, 18 Oct 2011 15:45:37 +0200 [thread overview]
Message-ID: <20111018134537.GA17055@gondor.apana.org.au> (raw)
In-Reply-To: <1318942560.2657.69.camel@edumazet-HP-Compaq-6005-Pro-SFF-PC>
On Tue, Oct 18, 2011 at 02:56:00PM +0200, Eric Dumazet wrote:
>
> I am ok by this way, but we might hit another similar problem elsewhere.
>
> (igmp.c ip6_output, ...)
>
> We effectively want to remove LL_ALLOCATED_SPACE() usage and obfuscate
> code...
Here's another idea, provide a helper to do the skb allocation
and the skb_reserve in one go. That way this ugliness would only
need to be done once.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2011-10-18 13:45 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-14 8:08 Elmar Vonlanthen
2011-10-14 14:57 ` Eric Dumazet
2011-10-17 7:16 ` Elmar Vonlanthen
2011-10-18 2:30 ` Eric Dumazet
2011-10-18 9:34 ` Herbert Xu
2011-10-18 10:01 ` Eric Dumazet
2011-10-18 10:05 ` Herbert Xu
2011-10-18 10:23 ` Eric Dumazet
2011-10-18 10:45 ` Herbert Xu
2011-10-18 11:37 ` Eric Dumazet
2011-10-18 11:49 ` Herbert Xu
2011-10-18 12:56 ` Eric Dumazet
2011-10-18 13:45 ` Herbert Xu [this message]
2011-10-19 7:09 ` David Miller
2011-10-19 7:18 ` Eric Dumazet
2011-10-19 7:30 ` David Miller
2011-10-19 7:52 ` Eric Dumazet
2011-10-19 8:02 ` David Miller
2011-10-19 8:08 ` Herbert Xu
2011-10-20 9:30 ` David Miller
2011-10-20 9:35 ` Herbert Xu
2011-10-20 20:21 ` David Miller
2011-10-25 11:54 ` Herbert Xu
2011-10-26 3:12 ` David Miller
2011-11-18 12:18 ` [0/6] Replace LL_ALLOCATED_SPACE to allow needed_headroom adjustment Herbert Xu
2011-11-18 12:20 ` [PATCH 2/6] ipv6: Remove all uses of LL_ALLOCATED_SPACE Herbert Xu
2011-11-18 12:20 ` [PATCH 3/6] net: " Herbert Xu
2011-11-18 12:20 ` [PATCH 1/6] ipv4: " Herbert Xu
2011-11-18 12:20 ` [PATCH 4/6] net: Remove LL_ALLOCATED_SPACE Herbert Xu
2011-11-18 12:20 ` [PATCH 5/6] packet: Add needed_tailroom to packet_sendmsg_spkt Herbert Xu
2011-11-18 12:20 ` [PATCH 6/6] ip_gre: Set needed_headroom dynamically again Herbert Xu
2011-11-18 20:01 ` [0/6] Replace LL_ALLOCATED_SPACE to allow needed_headroom adjustment David Miller
[not found] <CA+0Zf5C1B67f7RSiEej86rGFC1Ms9vH-qmk1wN1phtskfq2vEA@mail.gmail.com>
2011-10-13 13:35 ` PROBLEM: System call 'sendmsg' of process ospfd (quagga) causes kernel oops Elmar Vonlanthen
2011-10-13 13:54 ` Elmar Vonlanthen
-- strict thread matches above, loose matches on Subject: below --
2011-10-13 8:56 Elmar Vonlanthen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20111018134537.GA17055@gondor.apana.org.au \
--to=herbert@gondor.hengli.com.au \
--cc=eric.dumazet@gmail.com \
--cc=evonlanthen@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=timo.teras@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®