From: James Ogletree <James.Ogletree@cirrus.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
Cc: Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Fred Treven <Fred.Treven@cirrus.com>,
Ben Bright <Ben.Bright@cirrus.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>, Lee Jones <lee@kernel.org>,
Peng Fan <peng.fan@nxp.com>, Jean Delvare <jdelvare@suse.de>,
Jeff LaBundy <jeff@labundy.com>,
Randy Dunlap <rdunlap@infradead.org>,
Arnd Bergmann <arnd@arndb.de>,
Eddie James <eajames@linux.ibm.com>, Jacky Bai <ping.bai@nxp.com>,
Markus Schneider-Pargmann <msp@baylibre.com>,
ChiYuan Huang <cy_huang@richtek.com>,
Jerome Neanne <jneanne@baylibre.com>,
"patches@cirrus.com" <patches@cirrus.com>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/2] Input: cs40l50 - Initial support for Cirrus Logic CS40L50
Date: Mon, 14 Aug 2023 21:44:33 +0000 [thread overview]
Message-ID: <E3A9D2CF-333D-4238-8013-346135AC001B@cirrus.com> (raw)
In-Reply-To: <3f406442-d46e-7f9e-426d-22a96f893103@linaro.org>
> On Aug 10, 2023, at 1:12 AM, Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote:
>
> On 09/08/2023 20:02, James Ogletree wrote:
>>>> + if (cs40l50->vibe_workqueue) {
>>>> + flush_workqueue(cs40l50->vibe_workqueue);
>>>> + destroy_workqueue(cs40l50->vibe_workqueue);
>>>> + }
>>>> +
>>>> + gpiod_set_value_cansleep(cs40l50->reset_gpio, 1);
>>>> + regulator_bulk_disable(ARRAY_SIZE(cs40l50_supplies), cs40l50_supplies);
>>>> +
>>>> + return 0;
>>>> +}
>>>> +EXPORT_SYMBOL_GPL(cs40l50_remove);
>>>> +
>>>> +MODULE_DESCRIPTION("CS40L50 Advanced Haptic Driver");
>>>> +MODULE_AUTHOR("James Ogletree, Cirrus Logic Inc. <james.ogletree@cirrus.com>");
>>>> +MODULE_LICENSE("GPL");
>>>
>>> I don't think this is a module.
>>
>> It can be compiled as a module with CONFIG_INPUT_CS40L50=m. However, there is a
>> typo in the Kconfig entry description: the module will be called “cs40l50” not “cs40l50-core”.
>> That will be fixed.
>
> Really, *this* unit file can be compiled as module? Where is the
> module_xxx_driver() then?
>
As I understand it, the “module_XXX_driver()” has nothing to do with whether or not the file is built as a module, rather it just provides code to attach the driver to a bus. But this is a bus-agnostic, separate module (not a driver in itself) that provides implementation to cs40l26-i2c or cs40l26-spi drivers, which do contain that macro as they should. This doesn’t appear to be an uncommon pattern.
Regards,
James
next prev parent reply other threads:[~2023-08-14 21:46 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-08 17:25 [PATCH 1/2] dt-bindings: input: cirrus,cs40l50: Support for CS40L50 James Ogletree
2023-08-08 17:25 ` [PATCH 2/2] Input: cs40l50 - Initial support for Cirrus Logic CS40L50 James Ogletree
2023-08-09 6:47 ` Krzysztof Kozlowski
2023-08-09 18:02 ` James Ogletree
2023-08-10 6:12 ` Krzysztof Kozlowski
2023-08-14 21:44 ` James Ogletree [this message]
2023-08-15 5:08 ` Krzysztof Kozlowski
2023-08-09 6:43 ` [PATCH 1/2] dt-bindings: input: cirrus,cs40l50: Support for CS40L50 Krzysztof Kozlowski
2023-08-09 16:41 ` James Ogletree
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=E3A9D2CF-333D-4238-8013-346135AC001B@cirrus.com \
--to=james.ogletree@cirrus.com \
--cc=Ben.Bright@cirrus.com \
--cc=Fred.Treven@cirrus.com \
--cc=arnd@arndb.de \
--cc=conor+dt@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=eajames@linux.ibm.com \
--cc=jdelvare@suse.de \
--cc=jeff@labundy.com \
--cc=jneanne@baylibre.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=krzysztof.kozlowski@linaro.org \
--cc=lee@kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=msp@baylibre.com \
--cc=patches@cirrus.com \
--cc=peng.fan@nxp.com \
--cc=ping.bai@nxp.com \
--cc=rdunlap@infradead.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®