From: "Drokin, Oleg" <oleg.drokin@intel.com>
To: Anjali Menon <cse.anjalimenon@gmail.com>
Cc: "<gregkh@linuxfoundation.org>" <gregkh@linuxfoundation.org>,
"<HPDD-discuss@lists.01.org>" <HPDD-discuss@ml01.01.org>,
"<devel@driverdev.osuosl.org>" <devel@driverdev.osuosl.org>,
"<linux-kernel@vger.kernel.org>" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] staging: lustre: lustre: llite: Added a blank line
Date: Sat, 3 Oct 2015 15:53:22 +0000 [thread overview]
Message-ID: <EBCBEFD4-5FD8-449C-81DB-84F27D52C198@intel.com> (raw)
In-Reply-To: <1443872363-6043-1-git-send-email-cse.anjalimenon@gmail.com>
On Oct 3, 2015, at 7:39 AM, Anjali Menon wrote:
> Added a blank line after declaration to fix the coding
> style warning detected by checkpatch.pl
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
> index aec9a44..a626871 100644
> --- a/drivers/staging/lustre/lustre/llite/llite_capa.c
> +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
> @@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct list_head *head)
> static inline int obd_capa_open_count(struct obd_capa *oc)
This whole file has been recently removed.
In general at least with Lustre (and probably with other staging code) it's best to
base your work on Greg's staging-next (or even staging-testing) tree because this
is where the most up to date code is (And this is where Greg tries to apply it anyway).
> {
> struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
> +
> return atomic_read(&lli->lli_open_count);
> }
>
> --
> 1.9.1
>
prev parent reply other threads:[~2015-10-03 15:53 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-10-03 11:39 Anjali Menon
2015-10-03 15:53 ` Drokin, Oleg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=EBCBEFD4-5FD8-449C-81DB-84F27D52C198@intel.com \
--to=oleg.drokin@intel.com \
--cc=HPDD-discuss@ml01.01.org \
--cc=cse.anjalimenon@gmail.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®