* [PATCH] staging: lustre: lustre: llite: Added a blank line
@ 2015-10-03 11:39 Anjali Menon
2015-10-03 15:53 ` Drokin, Oleg
0 siblings, 1 reply; 2+ messages in thread
From: Anjali Menon @ 2015-10-03 11:39 UTC (permalink / raw)
To: oleg.drokin; +Cc: gregkh, HPDD-discuss, devel, linux-kernel, Anjali Menon
Added a blank line after declaration to fix the coding
style warning detected by checkpatch.pl
WARNING: Missing a blank line after declarations
Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
---
drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
index aec9a44..a626871 100644
--- a/drivers/staging/lustre/lustre/llite/llite_capa.c
+++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
@@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct list_head *head)
static inline int obd_capa_open_count(struct obd_capa *oc)
{
struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
+
return atomic_read(&lli->lli_open_count);
}
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] staging: lustre: lustre: llite: Added a blank line
2015-10-03 11:39 [PATCH] staging: lustre: lustre: llite: Added a blank line Anjali Menon
@ 2015-10-03 15:53 ` Drokin, Oleg
0 siblings, 0 replies; 2+ messages in thread
From: Drokin, Oleg @ 2015-10-03 15:53 UTC (permalink / raw)
To: Anjali Menon
Cc: <gregkh@linuxfoundation.org>,
<HPDD-discuss@lists.01.org>,
<devel@driverdev.osuosl.org>,
<linux-kernel@vger.kernel.org>
On Oct 3, 2015, at 7:39 AM, Anjali Menon wrote:
> Added a blank line after declaration to fix the coding
> style warning detected by checkpatch.pl
>
> WARNING: Missing a blank line after declarations
>
> Signed-off-by: Anjali Menon <cse.anjalimenon@gmail.com>
> ---
> drivers/staging/lustre/lustre/llite/llite_capa.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/staging/lustre/lustre/llite/llite_capa.c b/drivers/staging/lustre/lustre/llite/llite_capa.c
> index aec9a44..a626871 100644
> --- a/drivers/staging/lustre/lustre/llite/llite_capa.c
> +++ b/drivers/staging/lustre/lustre/llite/llite_capa.c
> @@ -140,6 +140,7 @@ static void sort_add_capa(struct obd_capa *ocapa, struct list_head *head)
> static inline int obd_capa_open_count(struct obd_capa *oc)
This whole file has been recently removed.
In general at least with Lustre (and probably with other staging code) it's best to
base your work on Greg's staging-next (or even staging-testing) tree because this
is where the most up to date code is (And this is where Greg tries to apply it anyway).
> {
> struct ll_inode_info *lli = ll_i2info(oc->u.cli.inode);
> +
> return atomic_read(&lli->lli_open_count);
> }
>
> --
> 1.9.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2015-10-03 15:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2015-10-03 11:39 [PATCH] staging: lustre: lustre: llite: Added a blank line Anjali Menon
2015-10-03 15:53 ` Drokin, Oleg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®