From: "Andrejczuk, Grzegorz" <grzegorz.andrejczuk@intel.com>
To: Borislav Petkov <bp@suse.de>
Cc: "tglx@linutronix.de" <tglx@linutronix.de>,
"mingo@redhat.com" <mingo@redhat.com>,
"hpa@zytor.com" <hpa@zytor.com>,
"x86@kernel.org" <x86@kernel.org>,
"dave.hansen@linux.intel.com" <dave.hansen@linux.intel.com>,
"Daniluk, Lukasz" <lukasz.daniluk@intel.com>,
"Cownie, James H" <james.h.cownie@intel.com>,
"Pan, Jacob jun" <jacob.jun.pan@intel.com>,
"Luc, Piotr" <Piotr.Luc@intel.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v6: 4/4] x86/cpufeature: Add R3MWAIT to CPU features
Date: Thu, 27 Oct 2016 16:46:54 +0000 [thread overview]
Message-ID: <ED52C51D9B87F54892CE544909A13C6C1FF65B1D@IRSMSX101.ger.corp.intel.com> (raw)
In-Reply-To: <20161027143015.friq4ji5wahr2cyu@pd.tnic>
> On Thu, Oct 27, 2016 at 04:02:03PM +0200, Grzegorz Andrejczuk wrote:
> > Add cpu feature for ring 3 monitor/mwait.
> > Set HWCAP2 1st bit during init.
> >
> > Signed-off-by: Grzegorz Andrejczuk <grzegorz.andrejczuk@intel.com>
> > ---
> > arch/x86/include/asm/cpufeatures.h | 2 ++
> > arch/x86/kernel/cpu/intel.c | 4 ++++
> > 2 files changed, 6 insertions(+)
> >
> > diff --git a/arch/x86/include/asm/cpufeatures.h
> > b/arch/x86/include/asm/cpufeatures.h
> > index 92a8308..d430200 100644
> > --- a/arch/x86/include/asm/cpufeatures.h
> > +++ b/arch/x86/include/asm/cpufeatures.h
> > @@ -71,6 +71,8 @@
> > #define X86_FEATURE_RECOVERY ( 2*32+ 0) /* CPU in recovery mode */
> > #define X86_FEATURE_LONGRUN ( 2*32+ 1) /* Longrun power control */
> > #define X86_FEATURE_LRTI ( 2*32+ 3) /* LongRun table interface */
> > +/* Xeon Phi x200 ring 3 MONITOR/MWAIT enabled */
> > +#define X86_FEATURE_PHIR3MWAIT ( 2*32+ 4)
>
> This leaf is for Transmeta CPUs:
>
> /* Transmeta-defined CPU features, CPUID level 0x80860001, word 2 */
>
> is KNL close to some Transmeta design, per chance or so?
>
> I mean, for this to work, it would have to implement CPUID leaf 0x80860001...
>
I was reusing Word 3 as you suggested in patch rev. 1. There was idea to use init_scattered_cpuid_features.
What is good place for this feature?
next prev parent reply other threads:[~2016-10-27 16:47 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-27 14:01 [PATCH v6 0/4] Enabling Ring 3 MONITOR/MWAIT feature for Knights Landing Grzegorz Andrejczuk
2016-10-27 14:02 ` [PATCH v6: 1/4] x86/msr: Add R3MWAIT register and bit to msr-info.h Grzegorz Andrejczuk
2016-10-27 14:32 ` Thomas Gleixner
2016-10-27 14:02 ` [PATCH v6: 2/4] x86: Add enabling of the R3MWAIT during boot Grzegorz Andrejczuk
2016-10-27 14:38 ` Thomas Gleixner
2016-10-27 16:53 ` Andrejczuk, Grzegorz
2016-10-27 18:22 ` Thomas Gleixner
2016-11-26 13:15 ` Pavel Machek
2016-11-26 13:20 ` Thomas Gleixner
2016-12-09 12:49 ` Andrejczuk, Grzegorz
2017-02-03 10:47 ` Pavel Machek
2017-02-03 11:28 ` Andrejczuk, Grzegorz
2016-10-27 14:02 ` [PATCH v6: 3/4] x86: Use HWCAP2 to expose Xeon Phi ring 3 MWAIT Grzegorz Andrejczuk
2016-10-27 14:02 ` [PATCH v6: 4/4] x86/cpufeature: Add R3MWAIT to CPU features Grzegorz Andrejczuk
2016-10-27 14:30 ` Borislav Petkov
2016-10-27 16:46 ` Andrejczuk, Grzegorz [this message]
2016-10-27 17:01 ` Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ED52C51D9B87F54892CE544909A13C6C1FF65B1D@IRSMSX101.ger.corp.intel.com \
--to=grzegorz.andrejczuk@intel.com \
--cc=Piotr.Luc@intel.com \
--cc=bp@suse.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jacob.jun.pan@intel.com \
--cc=james.h.cownie@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukasz.daniluk@intel.com \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®