From: Marcel Holtmann <marcel@holtmann.org>
To: Colin King <colin.king@canonical.com>
Cc: Johan Hedberg <johan.hedberg@gmail.com>,
Sean Wang <sean.wang@mediatek.com>,
Bluez mailing list <linux-bluetooth@vger.kernel.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Bluetooth: btusb: fix memory leak on fw
Date: Fri, 29 Nov 2019 20:22:05 +0100 [thread overview]
Message-ID: <F011BBCD-8D95-4934-AB3E-0F264990D4F2@holtmann.org> (raw)
In-Reply-To: <20191129173635.87479-1-colin.king@canonical.com>
Hi Colin,
> Currently the error return path when the call to btusb_mtk_hci_wmt_sync
> fails does not free fw. Fix this by returning via the error_release_fw
> label that performs the free'ing.
>
> Addresses-Coverity: ("Resource leak")
> Fixes: a1c49c434e15 ("Bluetooth: btusb: Add protocol support for MediaTek MT7668U USB devices")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>
> ---
> drivers/bluetooth/btusb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
patch has been applied to bluetooth-next tree.
Regards
Marcel
prev parent reply other threads:[~2019-11-29 19:22 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-29 17:36 Colin King
2019-11-29 19:22 ` Marcel Holtmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F011BBCD-8D95-4934-AB3E-0F264990D4F2@holtmann.org \
--to=marcel@holtmann.org \
--cc=colin.king@canonical.com \
--cc=johan.hedberg@gmail.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sean.wang@mediatek.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®