From: Daniel Almeida <dwlsalmeida@gmail.com>
To: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
Cc: mchehab@kernel.org, thomas.weissschuh@linutronix.de,
dingyihan@uniontech.com, linux-media@vger.kernel.org,
linux-kernel@vger.kernel.org,
syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com
Subject: Re: [PATCH v2] media: vidtv: fix pass-by-value structs causing MSAN warnings
Date: Sat, 21 Feb 2026 18:51:44 -0300 [thread overview]
Message-ID: <F2A6B415-6F78-4EBA-97FB-106028E3526B@gmail.com> (raw)
In-Reply-To: <20260221125618.133570-1-abd.masalkhi@gmail.com>
Hi there, thanks for your contribution.
> On 21 Feb 2026, at 09:56, Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com> wrote:
>
> vidtv_ts_null_write_into() and vidtv_ts_pcr_write_into() take their
> argument structs by value, causing MSAN to report uninit-value warnings.
> While only vidtv_ts_null_write_into() has triggered a report so far,
> both functions share the same issue.
>
> Fix by passing both structs by const pointer instead, avoiding the
> stack copy of the struct along with its MSAN shadow and origin metadata.
> The functions do not modify the structs, which is enforced by the const
> qualifier.
>
> Fixes: f90cf6079bf67 ("media: vidtv: add a bridge driver")
> Reported-by: syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com
> Closes: https://syzkaller.appspot.com/bug?extid=96f901260a0b2d29cd1a
> Tested-by: syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com
> Suggested-by: Yihan Ding <dingyihan@uniontech.com>
> Signed-off-by: Abd-Alrhman Masalkhi <abd.masalkhi@gmail.com>
> —
I will eventually get to this patch.
— Daniel
prev parent reply other threads:[~2026-02-21 21:52 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-21 12:56 Abd-Alrhman Masalkhi
2026-02-21 21:51 ` Daniel Almeida [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=F2A6B415-6F78-4EBA-97FB-106028E3526B@gmail.com \
--to=dwlsalmeida@gmail.com \
--cc=abd.masalkhi@gmail.com \
--cc=dingyihan@uniontech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=syzbot+96f901260a0b2d29cd1a@syzkaller.appspotmail.com \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®