mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnaldo Melo <arnaldo.melo@gmail.com>
To: Ian Rogers <irogers@google.com>,
	Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: James Clark <james.clark@linaro.org>,
	Besar Wicaksono <bwicaksono@nvidia.com>,
	namhyung@kernel.org, linux-tegra@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-perf-users@vger.kernel.org, linux-kernel@vger.kernel.org,
	vsethi@nvidia.com, rwiley@nvidia.com, skelley@nvidia.com,
	mochs@nvidia.com, rajjoshi@nvidia.com, treding@nvidia.com,
	jonathanh@nvidia.com, john.garry@linux.dev, will@kernel.org,
	mike.leach@arm.com, leo.yan@linux.dev, mark.rutland@arm.com,
	alexander.shishkin@linux.intel.com, jolsa@kernel.org,
	adrian.hunter@intel.com, ctshao@google.com
Subject: Re: [PATCH 0/6] perf jevents: Add NVIDIA Tegra410 uncore PMU events and metrics
Date: Tue, 20 Oct 2026 17:38:48 -0300	[thread overview]
Message-ID: <F2F3FF02-67B6-4EBF-BD4B-364C7CD28535@gmail.com> (raw)
In-Reply-To: <CAP-5=fXUMVJwtAp+8dA8V=hBD9q4x6J4YiUufwXAOXcAJoAKTg@mail.gmail.com>



On October 20, 2026 5:32:48 PM GMT-03:00, Ian Rogers <irogers@google.com> wrote:
>On Tue, Oct 20, 2026 at 12:15 PM Arnaldo Carvalho de Melo
><acme@kernel.org> wrote:
>>
>> On Mon, Oct 19, 2026 at 06:23:16PM +0100, James Clark wrote:
>> > On 19/10/2026 17:42, Besar Wicaksono wrote:
>> > > Add event aliases and derived metrics for the NVIDIA Tegra410 uncore
>> > > PMUs.
>>
>> > Reviewed-by: James Clark <james.clark@linaro.org>
>>
>> Thanks, applied to perf-tools-next, for v7.4.
>
>Hi Arnaldo,
>
>can we not take these in v7.4 as there is unaddressed feedback:
>https://lore.kernel.org/linux-perf-users/CAP-5=fWucvdYefDOL3Vn=O=YUPEXE+tngDDfPLv-T5i3WkCJVA@mail.gmail.com

Sure, will remove until the discussion comes to a conclusion. 

- Arnaldo 

>
>The specific problem is that the NVidia PMUs have adopted a convention
>not supported by the perf tool of 'pmu_name_<socket>_rc_<num>'. rc
>stands for root complex. What ends up happening is that aggregation is
>broken as the json is claiming that pmu_name is the PMU's name while
>the suffix perf_pmus code thinks pmu_name_<socket>_rc is the pmu name.
>They've wrangled support via the json by claiming these are sys
>events.
>
>We can either:
>1) support a new suffix convention of <num>_rc_<num>
>2) push back and ask the driver writers to name their PMU correctly as
>defined in the ABI:
>https://web.git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/ABI/testing/sysfs-bus-event_source-devices
>
>If we do (1) then it would be nice if the support for that could be
>contained in this patch series. In any case these events don't belong
>in sys.
>
>Thanks,
>Ian
>
>> - Arnaldo

- Arnaldo

  reply	other threads:[~2026-10-20 20:38 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-19 16:42 Besar Wicaksono
2026-10-19 16:42 ` [PATCH 1/6] perf jevents: Process model files before sys subdirectories Besar Wicaksono
2026-10-19 16:42 ` [PATCH 2/6] perf jevents: Add support for NVIDIA Tegra410 UCF PMU aliasing Besar Wicaksono
2026-10-19 16:42 ` [PATCH 3/6] perf jevents: Add support for NVIDIA Tegra410 PCIE " Besar Wicaksono
2026-10-19 17:50   ` Chun-Tse Shao
2026-10-19 16:42 ` [PATCH 4/6] perf jevents: Add support for NVIDIA Tegra410 PCIE-TGT " Besar Wicaksono
2026-10-19 23:18   ` Ian Rogers
2026-10-20 22:01     ` Besar Wicaksono
2026-10-20 23:12       ` Chun-Tse Shao
2026-10-19 16:42 ` [PATCH 5/6] perf jevents: Add support for NVIDIA Tegra410 CPU Memory Latency " Besar Wicaksono
2026-10-19 16:42 ` [PATCH 6/6] perf jevents: Add support for NVIDIA Tegra410 C2C " Besar Wicaksono
2026-10-19 17:23 ` [PATCH 0/6] perf jevents: Add NVIDIA Tegra410 uncore PMU events and metrics James Clark
2026-10-20 19:15   ` Arnaldo Carvalho de Melo
2026-10-20 20:32     ` Ian Rogers
2026-10-20 20:38       ` Arnaldo Melo [this message]
2026-10-20 22:14       ` Besar Wicaksono

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=F2F3FF02-67B6-4EBF-BD4B-364C7CD28535@gmail.com \
    --to=arnaldo.melo@gmail.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=alexander.shishkin@linux.intel.com \
    --cc=bwicaksono@nvidia.com \
    --cc=ctshao@google.com \
    --cc=irogers@google.com \
    --cc=james.clark@linaro.org \
    --cc=john.garry@linux.dev \
    --cc=jolsa@kernel.org \
    --cc=jonathanh@nvidia.com \
    --cc=leo.yan@linux.dev \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-perf-users@vger.kernel.org \
    --cc=linux-tegra@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mike.leach@arm.com \
    --cc=mochs@nvidia.com \
    --cc=namhyung@kernel.org \
    --cc=rajjoshi@nvidia.com \
    --cc=rwiley@nvidia.com \
    --cc=skelley@nvidia.com \
    --cc=treding@nvidia.com \
    --cc=vsethi@nvidia.com \
    --cc=will@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®