* [PATCH] selftests/thermal: Remove duplicate sprintf() call in workload_hint_test
@ 2025-07-10 13:04 WangYuli
2025-07-10 13:47 ` [PATCH] selftests/thermal: Remove duplicate newlines in perror calls WangYuli
0 siblings, 1 reply; 2+ messages in thread
From: WangYuli @ 2025-07-10 13:04 UTC (permalink / raw)
To: shuah, wangyuli, chelsyratnawat2001, akpm
Cc: linux-kselftest, linux-kernel, zhanjun, niecheng1, guanwentao
Remove redundant sprintf() call that was duplicating the same operation
of formatting delay_str with argv[1].
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
.../selftests/thermal/intel/workload_hint/workload_hint_test.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
index a40097232967..bda006af8b1b 100644
--- a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
+++ b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
@@ -67,8 +67,6 @@ int main(int argc, char **argv)
if (delay < 0)
exit(1);
- sprintf(delay_str, "%s\n", argv[1]);
-
sprintf(delay_str, "%s\n", argv[1]);
fd = open(WORKLOAD_NOTIFICATION_DELAY_ATTRIBUTE, O_RDWR);
if (fd < 0) {
--
2.50.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* [PATCH] selftests/thermal: Remove duplicate newlines in perror calls
2025-07-10 13:04 [PATCH] selftests/thermal: Remove duplicate sprintf() call in workload_hint_test WangYuli
@ 2025-07-10 13:47 ` WangYuli
0 siblings, 0 replies; 2+ messages in thread
From: WangYuli @ 2025-07-10 13:47 UTC (permalink / raw)
To: wangyuli
Cc: akpm, chelsyratnawat2001, guanwentao, linux-kernel,
linux-kselftest, niecheng1, shuah, zhanjun
The perror() function automatically appends a newline character,
so the explicit '\n' in the format strings is redundant and results
in duplicate newlines in the output.
Remove the redundant '\n' characters from perror() calls in
workload_hint_test.c to fix the formatting.
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
.../intel/workload_hint/workload_hint_test.c | 14 +++++++-------
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
index bda006af8b1b..ba58589a1145 100644
--- a/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
+++ b/tools/testing/selftests/thermal/intel/workload_hint/workload_hint_test.c
@@ -32,12 +32,12 @@ void workload_hint_exit(int signum)
fd = open(WORKLOAD_ENABLE_ATTRIBUTE, O_RDWR);
if (fd < 0) {
- perror("Unable to open workload type feature enable file\n");
+ perror("Unable to open workload type feature enable file");
exit(1);
}
if (write(fd, "0\n", 2) < 0) {
- perror("Can't disable workload hints\n");
+ perror("Can't disable workload hints");
exit(1);
}
@@ -70,12 +70,12 @@ int main(int argc, char **argv)
sprintf(delay_str, "%s\n", argv[1]);
fd = open(WORKLOAD_NOTIFICATION_DELAY_ATTRIBUTE, O_RDWR);
if (fd < 0) {
- perror("Unable to open workload notification delay\n");
+ perror("Unable to open workload notification delay");
exit(1);
}
if (write(fd, delay_str, strlen(delay_str)) < 0) {
- perror("Can't set delay\n");
+ perror("Can't set delay");
exit(1);
}
@@ -92,12 +92,12 @@ int main(int argc, char **argv)
/* Enable feature via sysfs knob */
fd = open(WORKLOAD_ENABLE_ATTRIBUTE, O_RDWR);
if (fd < 0) {
- perror("Unable to open workload type feature enable file\n");
+ perror("Unable to open workload type feature enable file");
exit(1);
}
if (write(fd, "1\n", 2) < 0) {
- perror("Can't enable workload hints\n");
+ perror("Can't enable workload hints");
exit(1);
}
@@ -108,7 +108,7 @@ int main(int argc, char **argv)
while (1) {
fd = open(WORKLOAD_TYPE_INDEX_ATTRIBUTE, O_RDONLY);
if (fd < 0) {
- perror("Unable to open workload type file\n");
+ perror("Unable to open workload type file");
exit(1);
}
--
2.50.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2025-07-10 13:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-07-10 13:04 [PATCH] selftests/thermal: Remove duplicate sprintf() call in workload_hint_test WangYuli
2025-07-10 13:47 ` [PATCH] selftests/thermal: Remove duplicate newlines in perror calls WangYuli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®