From: Ed Cashin <ecashin@coraid.com>
To: linux-kernel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, Julia Lawall <julia@diku.dk>
Subject: Re: [PATCH 35/37] drivers/block/aoe: Use kmemdup
Date: Sun, 16 May 2010 08:42:59 -0400 [thread overview]
Message-ID: <FA04A0D0-4BAF-4E1D-B8E8-3148E290009F@coraid.com> (raw)
In-Reply-To: <Pine.LNX.4.64.1005152323310.21345@ask.diku.dk>
On May 15, 2010, at 5:23 PM, Julia Lawall wrote:
> From: Julia Lawall <julia@diku.dk>
>
> Use kmemdup when some other buffer is immediately copied into the
> allocated region.
I have seen this patch but have no comment about it specifically.
(Because the argument about whether this kind of change
adds value in general has already taken place. I'd say no, but that's
based on a maybe faulty idea that if folks weren't doing this they'd have
more time for reviewing patches, etc.)
--
Ed Cashin
ecashin@coraid.com
next prev parent reply other threads:[~2010-05-16 12:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-15 21:23 Julia Lawall
2010-05-16 12:42 ` Ed Cashin [this message]
2010-05-16 15:50 ` Dan Carpenter
2010-05-16 16:03 ` Julia Lawall
2010-05-16 16:38 ` Pekka Enberg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=FA04A0D0-4BAF-4E1D-B8E8-3148E290009F@coraid.com \
--to=ecashin@coraid.com \
--cc=julia@diku.dk \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®