mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian Kohlschütter" <christian@kohlschutter.com>
To: Mark Brown <broonie@kernel.org>
Cc: Liam Girdwood <lgirdwood@gmail.com>,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: [PATCH REBASE] regulator: core: Fix off-on-delay-us for always-on/boot-on regulators
Date: Tue, 19 Jul 2022 16:02:00 +0200	[thread overview]
Message-ID: <FAFD5B39-E9C4-47C7-ACF1-2A04CD59758D@kohlschutter.com> (raw)
In-Reply-To: <3270C618-E361-4BC1-B63A-917AE09DA60E@kohlschuetter.com>

Regulators marked with "regulator-always-on" or "regulator-boot-on"
as well as an "off-on-delay-us", may run into cycling issues that are
hard to detect.

This is caused by the "last_off" state not being initialized in this
case.

Fix the "last_off" initialization by setting it to the current kernel
time upon initialization, regardless of always_on/boot_on state.

Signed-off-by: Christian Kohlschütter <christian@kohlschutter.com>
---
drivers/regulator/core.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/regulator/core.c b/drivers/regulator/core.c
index 1e54a833f..398c8d6af 100644
--- a/drivers/regulator/core.c
+++ b/drivers/regulator/core.c
@@ -1565,6 +1565,9 @@ static int set_machine_constraints(struct regulator_dev *rdev)
			rdev->constraints->always_on = true;
	}

+	if (rdev->desc->off_on_delay)
+		rdev->last_off = ktime_get();
+
	/* If the constraints say the regulator should be on at this point
	 * and we have control then make sure it is enabled.
	 */
@@ -1592,8 +1595,6 @@ static int set_machine_constraints(struct regulator_dev *rdev)

		if (rdev->constraints->always_on)
			rdev->use_count++;
-	} else if (rdev->desc->off_on_delay) {
-		rdev->last_off = ktime_get();
	}

	print_constraints(rdev);
-- 
2.36.1


  parent reply	other threads:[~2022-07-19 14:20 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-07-17 11:30 [PATCH] " Christian Kohlschuetter
2022-07-17 11:39 ` Christian Kohlschütter
2022-07-17 11:49   ` Christian Kohlschütter
2022-07-18 12:36 ` Mark Brown
2022-07-18 17:24   ` [PATCH REBASE] " Christian Kohlschuetter
2022-07-19 13:57     ` [PATCH] " Mark Brown
2022-07-19 14:02       ` Christian Kohlschuetter
2022-07-19 14:02     ` Christian Kohlschütter [this message]
2022-07-19 14:27       ` [PATCH REBASE] " Mark Brown
2022-07-19 14:29       ` Mark Brown
2022-07-19 18:49         ` Christian Kohlschütter
2022-07-19 19:38           ` Mark Brown
2022-07-19 19:39             ` Christian Kohlschütter
2022-07-19 18:48       ` Mark Brown
2022-07-19 18:54         ` Christian Kohlschütter
2022-07-19 18:48     ` Mark Brown
2022-07-19 18:48 ` [PATCH] " Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=FAFD5B39-E9C4-47C7-ACF1-2A04CD59758D@kohlschutter.com \
    --to=christian@kohlschutter.com \
    --cc=broonie@kernel.org \
    --cc=lgirdwood@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®