mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Claudiu Manoil <claudiu.manoil@nxp.com>
To: Wei Fang <wei.fang@nxp.com>
Cc: dl-S32 <S32@nxp.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	Vladimir Oltean <vladimir.oltean@nxp.com>,
	Clark Wang <xiaoning.wang@nxp.com>,
	Andrew Lunn <andrew+netdev@lunn.ch>,
	"David S. Miller" <davem@davemloft.net>,
	Eric Dumazet <edumazet@kernel.org>,
	Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
	"imx@lists.linux.dev" <imx@lists.linux.dev>,
	"netdev@vger.kernel.org" <netdev@vger.kernel.org>
Subject: RE: [PATCH net-next v2 2/5] net: enetc: Enable probing of version 4.4 devices
Date: Thu, 15 Oct 2026 13:31:55 +0000	[thread overview]
Message-ID: <GV2PR04MB11740EA88D41475BADA25F116969C2@GV2PR04MB11740.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <AS4PR04MB9338EE95020485A9C5C45BCD889C2@AS4PR04MB9338.eurprd04.prod.outlook.com>


NXP Confidential
> From: Wei Fang <wei.fang@nxp.com>
> Sent: Thursday, October 15, 2026 4:42 AM
[...]
> Subject: RE: [PATCH net-next v2 2/5] net: enetc: Enable probing of version 4.4
> devices
>
> > +   { .revision = ENETC_REV_4_4,
> > +     .dev_id = NXP_ENETC_PPM_DEV_ID,
> > +     .data = &enetc4_ppm_data,
> > +   },
>
> You have reused driver data of the i.MX94, which has a system clock
> frequency of 333 MHz. However, for the S32N7, I think its system
> clock frequency to be 500 MHz. And the system clock frequency is
> used for DIM. Therefore, you'd better to add the new driver data
> for S32N7.
>

Ok, wanted to deal with the NETC frequency of S32N79 later, but I'll
look into adding this info in v3.  This is not a functional issue, the driver
still works with the 'old' frequency, but it may affect indeed the performance
of interrupt coalescing.

  reply	other threads:[~2026-10-15 13:32 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-13 17:12 [PATCH net-next v2 0/5] net: enetc: S32N79 pseudo-MAC (PPM) networking support Claudiu Manoil
2026-10-13 17:12 ` [PATCH net-next v2 1/5] net: enetc: Add pseudo-MAC support for ENETCv4 Ports via a fixed-link node Claudiu Manoil
2026-10-15  2:16   ` Wei Fang
2026-10-15 13:20     ` Claudiu Manoil
2026-10-15  8:43   ` kernel test robot
2026-10-15 13:26     ` Claudiu Manoil
2026-10-13 17:12 ` [PATCH net-next v2 2/5] net: enetc: Enable probing of version 4.4 devices Claudiu Manoil
2026-10-15  1:42   ` Wei Fang
2026-10-15 13:31     ` Claudiu Manoil [this message]
2026-10-13 17:12 ` [PATCH net-next v2 3/5] arm64: dts: s32n79: add NETC IEP18 ECAM node for ENETC PPM ports Claudiu Manoil
2026-10-13 17:12 ` [PATCH net-next v2 4/5] arm64: dts: s32n79-rdb: enable NETC IEP18 Claudiu Manoil
2026-10-13 17:12 ` [PATCH net-next v2 5/5] PCI: Create OF node for NXP ENETC pseudo-MAC functions Claudiu Manoil
2026-10-16  8:15 [PATCH net-next v2 2/5] net: enetc: Enable probing of version 4.4 devices netdev-bot+sashiko
2026-11-03  9:52 ` Claudiu Manoil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=GV2PR04MB11740EA88D41475BADA25F116969C2@GV2PR04MB11740.eurprd04.prod.outlook.com \
    --to=claudiu.manoil@nxp.com \
    --cc=S32@nxp.com \
    --cc=andrew+netdev@lunn.ch \
    --cc=davem@davemloft.net \
    --cc=edumazet@kernel.org \
    --cc=imx@lists.linux.dev \
    --cc=kuba@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=pabeni@redhat.com \
    --cc=vladimir.oltean@nxp.com \
    --cc=wei.fang@nxp.com \
    --cc=xiaoning.wang@nxp.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®