* [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()
@ 2021-03-05 3:49 'Wei Yongjun
2021-03-07 15:54 ` Paul Cercueil
2021-03-15 10:31 ` Vinod Koul
0 siblings, 2 replies; 3+ messages in thread
From: 'Wei Yongjun @ 2021-03-05 3:49 UTC (permalink / raw)
To: weiyongjun1, Kishon Vijay Abraham I, Vinod Koul, Paul Cercueil,
周琰杰 (Zhou Yanjie),
漆鹏振 (Qi Pengzhen)
Cc: linux-phy, linux-kernel, kernel-janitors, Hulk Robot
From: Wei Yongjun <weiyongjun1@huawei.com>
Fix the return value check typo which testing the wrong variable
in ingenic_usb_phy_probe().
Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic PHY framework.")
Reported-by: Hulk Robot <hulkci@huawei.com>
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
---
drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c b/drivers/phy/ingenic/phy-ingenic-usb.c
index ea127b177f46..28c28d816484 100644
--- a/drivers/phy/ingenic/phy-ingenic-usb.c
+++ b/drivers/phy/ingenic/phy-ingenic-usb.c
@@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct platform_device *pdev)
}
priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);
- if (IS_ERR(priv))
- return PTR_ERR(priv);
+ if (IS_ERR(priv->phy))
+ return PTR_ERR(priv->phy);
phy_set_drvdata(priv->phy, priv);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()
2021-03-05 3:49 [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe() 'Wei Yongjun
@ 2021-03-07 15:54 ` Paul Cercueil
2021-03-15 10:31 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Paul Cercueil @ 2021-03-07 15:54 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Kishon Vijay Abraham I, Vinod Koul, 周琰杰,
漆鹏振,
linux-phy, linux-kernel, kernel-janitors, Hulk Robot
Le ven. 5 mars 2021 à 3:49, 'Wei Yongjun <weiyongjun1@huawei.com> a
écrit :
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check typo which testing the wrong variable
> in ingenic_usb_phy_probe().
>
> Fixes: 31de313dfdcf ("PHY: Ingenic: Add USB PHY driver using generic
> PHY framework.")
> Reported-by: Hulk Robot <hulkci@huawei.com>
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Paul Cercueil <paul@crapouillou.net>
Cheers,
-Paul
> ---
> drivers/phy/ingenic/phy-ingenic-usb.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/phy/ingenic/phy-ingenic-usb.c
> b/drivers/phy/ingenic/phy-ingenic-usb.c
> index ea127b177f46..28c28d816484 100644
> --- a/drivers/phy/ingenic/phy-ingenic-usb.c
> +++ b/drivers/phy/ingenic/phy-ingenic-usb.c
> @@ -352,8 +352,8 @@ static int ingenic_usb_phy_probe(struct
> platform_device *pdev)
> }
>
> priv->phy = devm_phy_create(dev, NULL, &ingenic_usb_phy_ops);
> - if (IS_ERR(priv))
> - return PTR_ERR(priv);
> + if (IS_ERR(priv->phy))
> + return PTR_ERR(priv->phy);
>
> phy_set_drvdata(priv->phy, priv);
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe()
2021-03-05 3:49 [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe() 'Wei Yongjun
2021-03-07 15:54 ` Paul Cercueil
@ 2021-03-15 10:31 ` Vinod Koul
1 sibling, 0 replies; 3+ messages in thread
From: Vinod Koul @ 2021-03-15 10:31 UTC (permalink / raw)
To: 'Wei Yongjun
Cc: Kishon Vijay Abraham I, Paul Cercueil,
周琰杰 (Zhou Yanjie),
漆鹏振 (Qi Pengzhen),
linux-phy, linux-kernel, kernel-janitors, Hulk Robot
On 05-03-21, 03:49, 'Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
>
> Fix the return value check typo which testing the wrong variable
> in ingenic_usb_phy_probe().
Applied, thanks
--
~Vinod
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-03-15 10:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-03-05 3:49 [PATCH -next] phy: ingenic: Fix a typo in ingenic_usb_phy_probe() 'Wei Yongjun
2021-03-07 15:54 ` Paul Cercueil
2021-03-15 10:31 ` Vinod Koul
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®