From: Aditya Garg <gargaditya08@live.com>
To: Johan Hovold <johan@kernel.org>
Cc: Sven Peter <sven@svenpeter.dev>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Felix Zhang <mrman@mrman314.tech>,
"linux-bluetooth@vger.kernel.org"
<linux-bluetooth@vger.kernel.org>,
"stable@vger.kernel.org" <stable@vger.kernel.org>,
Johan Hovold <johan+linaro@kernel.org>,
Hector Martin <marcan@marcan.st>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Orlando Chamberlain <orlandoch.dev@gmail.com>,
"kekrby@gmail.com" <kekrby@gmail.com>,
"admin@kodeit.net" <admin@kodeit.net>,
Janne Grunau <j@jannau.net>,
"asahi@lists.linux.dev" <asahi@lists.linux.dev>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3] Bluetooth: Fix Bluetooth for BCM4377 on T2 Intel MacBooks
Date: Thu, 4 Jan 2024 07:47:38 +0000 [thread overview]
Message-ID: <MA0P287MB021769BC136ED0B947683709B867A@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM> (raw)
In-Reply-To: <ZY1ly_uB8huYl5jO@hovoldconsulting.com>
> On 28-Dec-2023, at 5:41 PM, Johan Hovold <johan@kernel.org> wrote:
>
> On Thu, Dec 28, 2023 at 10:46:57AM +0100, Sven Peter wrote:
>
>>>> On Dec 27, 2023, at 11:30, Johan Hovold <johan@kernel.org> wrote:
>>
>>>> The commit you tracked this down to restored the original semantics for
>>> HCI_QUIRK_USE_BDADDR_PROPERTY, which means that it should only be set
>>> for devices with an invalid address.
>>>
>>> The Broadcom BCM4377 driver has so far been setting this flag
>>> unconditionally which now potentially results in also valid addresses
>>> being marked as invalid.
>>>
>>> I've just sent a patch that makes sure to only mark invalid addresses as
>>> invalid:
>>>
>>> https://lore.kernel.org/lkml/20231227101003.10534-1-johan+linaro@kernel.org/
>>>
>>> Note however that the flag still needs to be set in case your device
>>> lacks storage for a unique device address so you cannot simply drop it
>>> for some device classes as you do below (unless you are certain that
>>> these devices will always have a valid address).
>
>> We do know that though.
>>
>> BCM4377 is present on Apple’s x86 Macs and always has internal storage
>> for the address. If the board comes up without an address there’s nothing
>> much we can do because the address isn’t provided by ACPI or anything
>> else and setting the invalid address quirk for that situation seems appropriate.
>>
>> BCM4378/4387 is present on Apple’s ARM Macs and never has internal storage.
>> The address is always provided by our bootloader in the device tree.
>> These should always unconditionally set HCI_QUIRK_USE_BDADDR_PROPERTY
>> just like this patch does.
>
> Ok, good, then this patch and the one I posted are mostly equivalent
> assuming that the BCM4378/4387 return an invalid address during setup.
>
> This patch may be preferred as it does not need to rely on such
> assumptions, though.
>
> Johan
So what's the final take on this? Which one is gonna be merged upstream?
next prev parent reply other threads:[~2024-01-04 7:47 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 9:46 Sven Peter
2023-12-28 12:10 ` Johan Hovold
2024-01-04 7:47 ` Aditya Garg [this message]
2024-01-04 7:50 ` Sven Peter
2024-01-04 8:21 ` Johan Hovold
2024-01-04 8:23 ` Sven Peter
-- strict thread matches above, loose matches on Subject: below --
2023-12-25 20:01 Felix Zhang
2023-12-25 20:26 ` Paul Menzel
2023-12-27 10:30 ` Johan Hovold
2023-12-27 10:21 ` Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MA0P287MB021769BC136ED0B947683709B867A@MA0P287MB0217.INDP287.PROD.OUTLOOK.COM \
--to=gargaditya08@live.com \
--cc=admin@kodeit.net \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=bagasdotme@gmail.com \
--cc=j@jannau.net \
--cc=johan+linaro@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=johan@kernel.org \
--cc=kekrby@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcan@marcan.st \
--cc=marcel@holtmann.org \
--cc=mrman@mrman314.tech \
--cc=orlandoch.dev@gmail.com \
--cc=pmenzel@molgen.mpg.de \
--cc=stable@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®