From: Johan Hovold <johan@kernel.org>
To: Sven Peter <sven@svenpeter.dev>
Cc: Aditya Garg <gargaditya08@live.com>,
Paul Menzel <pmenzel@molgen.mpg.de>,
Felix Zhang <mrman@mrman314.tech>,
linux-bluetooth@vger.kernel.org, stable@vger.kernel.org,
Johan Hovold <johan+linaro@kernel.org>,
Hector Martin <marcan@marcan.st>,
Bagas Sanjaya <bagasdotme@gmail.com>,
Alyssa Rosenzweig <alyssa@rosenzweig.io>,
Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
Luiz Augusto von Dentz <luiz.dentz@gmail.com>,
Orlando Chamberlain <orlandoch.dev@gmail.com>,
kekrby@gmail.com, admin@kodeit.net, Janne Grunau <j@jannau.net>,
asahi@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Bluetooth: Fix Bluetooth for BCM4377 on T2 Intel MacBooks
Date: Thu, 4 Jan 2024 09:21:22 +0100 [thread overview]
Message-ID: <ZZZqgsjeY3R4YlVG@hovoldconsulting.com> (raw)
In-Reply-To: <86B7DC5B-B25A-4D55-BBC7-A1C3EE8AC703@svenpeter.dev>
On Thu, Jan 04, 2024 at 08:50:19AM +0100, Sven Peter wrote:
> > On 4. Jan 2024, at 08:47, Aditya Garg <gargaditya08@live.com> wrote:
> >> On 28-Dec-2023, at 5:41 PM, Johan Hovold <johan@kernel.org> wrote:
> >> Ok, good, then this patch and the one I posted are mostly equivalent
> >> assuming that the BCM4378/4387 return an invalid address during setup.
> >>
> >> This patch may be preferred as it does not need to rely on such
> >> assumptions, though.
> > So what's the final take on this? Which one is gonna be merged upstream?
>
> I would’ve preferred this one (possibly with a better commit message)
> since it’s more explicit and doesn’t rely on additional assumptions
> but it looks like Johan’s version was already merged.
Which addresses do BCM4378/4387 return before they are configured?
Should be easy enough to verify that the current check for invalid
addresses catches those or otherwise add them to the list.
Johan
next prev parent reply other threads:[~2024-01-04 8:21 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-12-28 9:46 Sven Peter
2023-12-28 12:10 ` Johan Hovold
2024-01-04 7:47 ` Aditya Garg
2024-01-04 7:50 ` Sven Peter
2024-01-04 8:21 ` Johan Hovold [this message]
2024-01-04 8:23 ` Sven Peter
-- strict thread matches above, loose matches on Subject: below --
2023-12-25 20:01 Felix Zhang
2023-12-25 20:26 ` Paul Menzel
2023-12-27 10:30 ` Johan Hovold
2023-12-27 10:21 ` Neal Gompa
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ZZZqgsjeY3R4YlVG@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=admin@kodeit.net \
--cc=alyssa@rosenzweig.io \
--cc=asahi@lists.linux.dev \
--cc=bagasdotme@gmail.com \
--cc=gargaditya08@live.com \
--cc=j@jannau.net \
--cc=johan+linaro@kernel.org \
--cc=johan.hedberg@gmail.com \
--cc=kekrby@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luiz.dentz@gmail.com \
--cc=marcan@marcan.st \
--cc=marcel@holtmann.org \
--cc=mrman@mrman314.tech \
--cc=orlandoch.dev@gmail.com \
--cc=pmenzel@molgen.mpg.de \
--cc=stable@vger.kernel.org \
--cc=sven@svenpeter.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®