mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] scsi: aic94xx: fix use-after-free in device removal path
@ 2025-10-28 16:29 moonafterrain
  2025-11-20  4:16 ` Martin K. Petersen
  0 siblings, 1 reply; 2+ messages in thread
From: moonafterrain @ 2025-10-28 16:29 UTC (permalink / raw)
  To: James E . J . Bottomley, Martin K . Petersen
  Cc: linux-scsi, linux-kernel, stable, Yuhao Jiang, Junrui Luo

From: Junrui Luo <moonafterrain@outlook.com>

The asd_pci_remove() function fails to synchronize with pending tasklets
before freeing the asd_ha structure, leading to a potential use-after-free
vulnerability.

When a device removal is triggered (via hot-unplug or module unload), race condition can occur.

The fix adds tasklet_kill() before freeing the asd_ha structure, ensuring
all scheduled tasklets complete before cleanup proceeds.

Reported-by: Yuhao Jiang <danisjiang@gmail.com>
Reported-by: Junrui Luo <moonafterrain@outlook.com>
Fixes: 2908d778ab3e ("[SCSI] aic94xx: new driver")
Cc: stable@vger.kernel.org
Signed-off-by: Junrui Luo <moonafterrain@outlook.com>
---
 drivers/scsi/aic94xx/aic94xx_init.c | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/drivers/scsi/aic94xx/aic94xx_init.c b/drivers/scsi/aic94xx/aic94xx_init.c
index adf3d9145606..95f3620059f7 100644
--- a/drivers/scsi/aic94xx/aic94xx_init.c
+++ b/drivers/scsi/aic94xx/aic94xx_init.c
@@ -882,6 +882,9 @@ static void asd_pci_remove(struct pci_dev *dev)
 
 	asd_disable_ints(asd_ha);
 
+	/* Ensure all scheduled tasklets complete before freeing resources */
+	tasklet_kill(&asd_ha->seq.dl_tasklet);
+
 	asd_remove_dev_attrs(asd_ha);
 
 	/* XXX more here as needed */
-- 
2.51.1.dirty


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] scsi: aic94xx: fix use-after-free in device removal path
  2025-10-28 16:29 [PATCH] scsi: aic94xx: fix use-after-free in device removal path moonafterrain
@ 2025-11-20  4:16 ` Martin K. Petersen
  0 siblings, 0 replies; 2+ messages in thread
From: Martin K. Petersen @ 2025-11-20  4:16 UTC (permalink / raw)
  To: James E . J . Bottomley, moonafterrain
  Cc: Martin K . Petersen, linux-scsi, linux-kernel, stable, Yuhao Jiang

On Wed, 29 Oct 2025 00:29:04 +0800, moonafterrain@outlook.com wrote:

> The asd_pci_remove() function fails to synchronize with pending tasklets
> before freeing the asd_ha structure, leading to a potential use-after-free
> vulnerability.
> 
> When a device removal is triggered (via hot-unplug or module unload), race condition can occur.
> 
> The fix adds tasklet_kill() before freeing the asd_ha structure, ensuring
> all scheduled tasklets complete before cleanup proceeds.
> 
> [...]

Applied to 6.19/scsi-queue, thanks!

[1/1] scsi: aic94xx: fix use-after-free in device removal path
      https://git.kernel.org/mkp/scsi/c/f6ab594672d4

-- 
Martin K. Petersen

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2025-11-20  4:16 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-10-28 16:29 [PATCH] scsi: aic94xx: fix use-after-free in device removal path moonafterrain
2025-11-20  4:16 ` Martin K. Petersen

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®