From: "Sankeerth Billakanti (QUIC)" <quic_sbillaka@quicinc.com>
To: "dmitry.baryshkov@linaro.org" <dmitry.baryshkov@linaro.org>,
Stephen Boyd <swboyd@chromium.org>,
"Sankeerth Billakanti (QUIC)" <quic_sbillaka@quicinc.com>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"dri-devel@lists.freedesktop.org"
<dri-devel@lists.freedesktop.org>,
"freedreno@lists.freedesktop.org"
<freedreno@lists.freedesktop.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "robdclark@gmail.com" <robdclark@gmail.com>,
"seanpaul@chromium.org" <seanpaul@chromium.org>,
quic_kalyant <quic_kalyant@quicinc.com>,
"Abhinav Kumar (QUIC)" <quic_abhinavk@quicinc.com>,
"dianders@chromium.org" <dianders@chromium.org>,
"Kuogee Hsieh (QUIC)" <quic_khsieh@quicinc.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"sean@poorly.run" <sean@poorly.run>,
"airlied@linux.ie" <airlied@linux.ie>,
"daniel@ffwll.ch" <daniel@ffwll.ch>,
quic_vproddut <quic_vproddut@quicinc.com>,
"Aravind Venkateswaran (QUIC)" <quic_aravindh@quicinc.com>,
"steev@kali.org" <steev@kali.org>
Subject: RE: [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus
Date: Tue, 26 Apr 2022 01:58:58 +0000 [thread overview]
Message-ID: <MW4PR02MB71867AB85F2F4911B5B86E9CE1FB9@MW4PR02MB7186.namprd02.prod.outlook.com> (raw)
In-Reply-To: <664de9f0-a9a1-9b5e-9612-06a051c85434@linaro.org>
Hi Stephen,
>>>> Quoting Sankeerth Billakanti (2022-04-22 02:11:03)
>>>>> diff --git a/drivers/gpu/drm/msm/dp/dp_display.c
>>>>> b/drivers/gpu/drm/msm/dp/dp_display.c
>>>>> index d7a19d6..055681a 100644
>>>>> --- a/drivers/gpu/drm/msm/dp/dp_display.c
>>>>> +++ b/drivers/gpu/drm/msm/dp/dp_display.c
>>>>
>>>> Some nitpicks
>>>>
>>>> Reviewed-by: Stephen Boyd <swboyd@chromium.org>
>>>>
>>>>> @@ -1508,7 +1509,8 @@ void msm_dp_irq_postinstall(struct msm_dp
>>>>> *dp_display)
>>>>>
>>>>> dp_hpd_event_setup(dp);
>>>>>
>>>>> - dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
>>>>> + if (!dp_display->is_edp)
>>>>> + dp_add_event(dp, EV_HPD_INIT_SETUP, 0, 100);
>>>>
>>>> Did it turn out that in fact DP isn't ready still to setup even
>>>> after delaying the irq?
>>>>
>>>
>>> The host_init, config_hpd, phy_init and enable_irq are happening in
>modeset_init already for eDP.
>>> So, I am not scheduling the EV_HPD_INIT_SETUP event for eDP. I am not
>modifying the delay for DP.
>>
>> Cool. That didn't answer my question though. Why does DP still need
>> the delay? I thought recent changes made it unnecessary.
>
>I'd say that if it is not necessary, it should be changed in the separate commit.
>The question is valid nevertheless.
>
Yes, that is right. The delay is unnecessary with the recent changes.
Like Dmitry rightly suggested, we will remove the delay in a separate commit.
>
>--
>With best wishes
>Dmitry
next prev parent reply other threads:[~2022-04-26 1:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-22 9:11 [PATCH v9 0/4] Add support for the eDP panel over aux_bus Sankeerth Billakanti
2022-04-22 9:11 ` [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus Sankeerth Billakanti
2022-04-22 14:03 ` Doug Anderson
2022-04-23 0:13 ` Stephen Boyd
2022-04-25 9:39 ` Sankeerth Billakanti (QUIC)
2022-04-25 20:26 ` Stephen Boyd
2022-04-25 21:12 ` Dmitry Baryshkov
2022-04-26 1:58 ` Sankeerth Billakanti (QUIC) [this message]
2022-04-22 9:11 ` [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Sankeerth Billakanti
2022-04-22 14:03 ` Doug Anderson
2022-04-22 15:55 ` Doug Anderson
2022-04-22 16:04 ` Abhinav Kumar
2022-04-22 16:10 ` Doug Anderson
2022-04-22 17:35 ` Abhinav Kumar
2022-04-23 0:29 ` Stephen Boyd
2022-04-25 2:55 ` Sankeerth Billakanti (QUIC)
2022-04-25 20:27 ` Stephen Boyd
2022-04-26 3:45 ` Sankeerth Billakanti (QUIC)
2022-04-22 9:11 ` [PATCH v9 3/4] drm/msm/dp: wait for hpd high before aux transaction Sankeerth Billakanti
2022-04-23 1:38 ` Stephen Boyd
2022-04-22 9:11 ` [PATCH v9 4/4] drm/msm/dp: Support the eDP modes given by panel Sankeerth Billakanti
2022-04-23 1:39 ` Stephen Boyd
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=MW4PR02MB71867AB85F2F4911B5B86E9CE1FB9@MW4PR02MB7186.namprd02.prod.outlook.com \
--to=quic_sbillaka@quicinc.com \
--cc=airlied@linux.ie \
--cc=bjorn.andersson@linaro.org \
--cc=daniel@ffwll.ch \
--cc=devicetree@vger.kernel.org \
--cc=dianders@chromium.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=freedreno@lists.freedesktop.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=quic_abhinavk@quicinc.com \
--cc=quic_aravindh@quicinc.com \
--cc=quic_kalyant@quicinc.com \
--cc=quic_khsieh@quicinc.com \
--cc=quic_vproddut@quicinc.com \
--cc=robdclark@gmail.com \
--cc=sean@poorly.run \
--cc=seanpaul@chromium.org \
--cc=steev@kali.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®