mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Abhinav Kumar <quic_abhinavk@quicinc.com>
To: Doug Anderson <dianders@chromium.org>
Cc: Sankeerth Billakanti <quic_sbillaka@quicinc.com>,
	quic_kalyant <quic_kalyant@quicinc.com>,
	"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" 
	<devicetree@vger.kernel.org>,
	Bjorn Andersson <bjorn.andersson@linaro.org>,
	quic_vproddut <quic_vproddut@quicinc.com>,
	David Airlie <airlied@linux.ie>,
	linux-arm-msm <linux-arm-msm@vger.kernel.org>,
	LKML <linux-kernel@vger.kernel.org>,
	dri-devel <dri-devel@lists.freedesktop.org>,
	Stephen Boyd <swboyd@chromium.org>, Sean Paul <sean@poorly.run>,
	Sean Paul <seanpaul@chromium.org>,
	Steev Klimaszewski <steev@kali.org>,
	"Dmitry Baryshkov" <dmitry.baryshkov@linaro.org>,
	"Aravind Venkateswaran (QUIC)" <quic_aravindh@quicinc.com>,
	"Kuogee Hsieh (QUIC)" <quic_khsieh@quicinc.com>,
	freedreno <freedreno@lists.freedesktop.org>
Subject: Re: [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP
Date: Fri, 22 Apr 2022 10:35:13 -0700	[thread overview]
Message-ID: <c68e92ea-ee92-6aeb-1d51-5e265052ef43@quicinc.com> (raw)
In-Reply-To: <CAD=FV=Vu_0vxb_D+8n3qhNZ66nRXBp5vxshChmOM-ToPJxk=aA@mail.gmail.com>

Hi Doug

On 4/22/2022 9:10 AM, Doug Anderson wrote:
> Hi,
> 
> On Fri, Apr 22, 2022 at 9:05 AM Abhinav Kumar <quic_abhinavk@quicinc.com> wrote:
>>
>> Hi Doug
>>
>> For the lockdep error, the splat looks similar to what kuogee fixed
>> recently.
>>
>> Can you please check if below patch is present in your tree?
>>
>> https://patchwork.freedesktop.org/patch/481396/
> 
> Indeed I did have that in my tree already, but the lockdep splat is
> still there. I think the problem is that we're now calling
> dp_hpd_plug_handle() directly in dp_bridge_enable()
> 
> -Doug

Yes, now i understood this particular issue better and not sure how this 
wasn't caught. Perhaps some difference in the USE flags. Sankeerth didnt 
have lockdebug and thats why didnt hit this.

I have discussed with kuogee about why this change is needed and why 
this wasnt being done in get_modes().

It seems like originally, this was done for a quirk in the DP compliance 
equipment that it did not publish the fail safe mode ( even though some 
other modes were present ). Typically, any sink (as long as EDID read 
went through ) adds the 640x480 fail safe mode.

We could have done it in get_modes() even earlier but not sure how it 
was missed or was there some other reason.

Nonetheless, kuogee will post the change to move this to get_modes() 
shortly.

Thanks

Abhinav

  reply	other threads:[~2022-04-22 17:39 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-22  9:11 [PATCH v9 0/4] Add support for the eDP panel over aux_bus Sankeerth Billakanti
2022-04-22  9:11 ` [PATCH v9 1/4] drm/msm/dp: Add eDP support via aux_bus Sankeerth Billakanti
2022-04-22 14:03   ` Doug Anderson
2022-04-23  0:13   ` Stephen Boyd
2022-04-25  9:39     ` Sankeerth Billakanti (QUIC)
2022-04-25 20:26       ` Stephen Boyd
2022-04-25 21:12         ` Dmitry Baryshkov
2022-04-26  1:58           ` Sankeerth Billakanti (QUIC)
2022-04-22  9:11 ` [PATCH v9 2/4] drm/msm/dp: Support only IRQ_HPD and REPLUG interrupts for eDP Sankeerth Billakanti
2022-04-22 14:03   ` Doug Anderson
2022-04-22 15:55   ` Doug Anderson
2022-04-22 16:04     ` Abhinav Kumar
2022-04-22 16:10       ` Doug Anderson
2022-04-22 17:35         ` Abhinav Kumar [this message]
2022-04-23  0:29   ` Stephen Boyd
2022-04-25  2:55     ` Sankeerth Billakanti (QUIC)
2022-04-25 20:27       ` Stephen Boyd
2022-04-26  3:45         ` Sankeerth Billakanti (QUIC)
2022-04-22  9:11 ` [PATCH v9 3/4] drm/msm/dp: wait for hpd high before aux transaction Sankeerth Billakanti
2022-04-23  1:38   ` Stephen Boyd
2022-04-22  9:11 ` [PATCH v9 4/4] drm/msm/dp: Support the eDP modes given by panel Sankeerth Billakanti
2022-04-23  1:39   ` Stephen Boyd

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c68e92ea-ee92-6aeb-1d51-5e265052ef43@quicinc.com \
    --to=quic_abhinavk@quicinc.com \
    --cc=airlied@linux.ie \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=dmitry.baryshkov@linaro.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=freedreno@lists.freedesktop.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=quic_aravindh@quicinc.com \
    --cc=quic_kalyant@quicinc.com \
    --cc=quic_khsieh@quicinc.com \
    --cc=quic_sbillaka@quicinc.com \
    --cc=quic_vproddut@quicinc.com \
    --cc=sean@poorly.run \
    --cc=seanpaul@chromium.org \
    --cc=steev@kali.org \
    --cc=swboyd@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®